Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of solution for #19 allowing playlists to be searched. Based on refactoring in #81.
Use the search bar to match playlists with the search string in their name (case insensitive), and return up to 20 results.
I decided to take a search rather than column sorting approach since it seemed to better fit the use cases that have been coming up, and even if you sort on playlist name, it might still be necessary to page a long way to get to the playlist of interest.
I also didn't implement exporting of all the search results. This might be useful for some people but my goal isn't to provide every possible feature, but to make the most common use-cases easier, like using the tool to quickly export a single playlist.
The Export All facility can always be used along with custom post-processing for more advanced purposes.