Merged
Conversation
- Removes the duplication of playlist loading - Sets structure for searchable playlist data
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR paves the way for a cleaner implementation of playlist searching. The only user-facing change is a subtle difference in the way playlist loading is indicated (the spinning cog). If more UI interactions depend on it, the full progress bar felt a bit heavyweight, and besides I think for most users the loading should only be a matter of a few seconds.
Aside from some extraction and tidying, the most notable improvement here is the introduction of page-level caching for playlists.
This means that logging into Exportify and paging through playlists won't require any more requests than is currently the case, but certain operations like searching and exporting all playlists will fully populate the cache before proceeding, and use whatever has already been cached.