Skip to content

Playlist loading refactoring#81

Merged
watsonbox merged 2 commits intomasterfrom
feature/playlist-search-prep
Nov 25, 2020
Merged

Playlist loading refactoring#81
watsonbox merged 2 commits intomasterfrom
feature/playlist-search-prep

Conversation

@watsonbox
Copy link
Copy Markdown
Owner

@watsonbox watsonbox commented Nov 24, 2020

This PR paves the way for a cleaner implementation of playlist searching. The only user-facing change is a subtle difference in the way playlist loading is indicated (the spinning cog). If more UI interactions depend on it, the full progress bar felt a bit heavyweight, and besides I think for most users the loading should only be a matter of a few seconds.

Aside from some extraction and tidying, the most notable improvement here is the introduction of page-level caching for playlists.

This means that logging into Exportify and paging through playlists won't require any more requests than is currently the case, but certain operations like searching and exporting all playlists will fully populate the cache before proceeding, and use whatever has already been cached.

- Removes the duplication of playlist loading
- Sets structure for searchable playlist data
@watsonbox watsonbox self-assigned this Nov 24, 2020
@watsonbox watsonbox merged commit 6ba5eb8 into master Nov 25, 2020
@watsonbox watsonbox mentioned this pull request Nov 25, 2020
@watsonbox watsonbox deleted the feature/playlist-search-prep branch July 15, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant