Disable Automatic Activation of externref#4213
Closed
CryZe wants to merge 4 commits intowasm-bindgen:mainfrom
Closed
Disable Automatic Activation of externref#4213CryZe wants to merge 4 commits intowasm-bindgen:mainfrom
externref#4213CryZe wants to merge 4 commits intowasm-bindgen:mainfrom
Conversation
77ee2fd to
a2c62f0
Compare
Starting with Rust 1.82 `reference-types` is always present in the `target_features` section. The problem is that JS bundlers like Webpack can't currently handle the `reference-types` proposal. So for now there should not be any automatic detection of the feature and instead it should explicitly be enabled by the user.
a2c62f0 to
37502b9
Compare
Contributor
Author
|
Due to multivalue also being broken, my PR is rebased ontop of #4210 for now. |
This was referenced Oct 27, 2024
Member
|
Replaced by #4235. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with Rust 1.82
reference-typesis always present in thetarget_featuressection. The problem is that JS bundlers like Webpack can't currently handle thereference-typesproposal. So for now there should not be any automatic detection of the feature and instead it should explicitly be enabled by the user.Fixes #4211