Fixed invalid type annotation for multivalue returns#4210
Merged
daxpedda merged 4 commits intowasm-bindgen:mainfrom Oct 31, 2024
Merged
Fixed invalid type annotation for multivalue returns#4210daxpedda merged 4 commits intowasm-bindgen:mainfrom
daxpedda merged 4 commits intowasm-bindgen:mainfrom
Conversation
Contributor
Author
|
CI fails because CI uses the latest stable compiler (Rust 1.82 now), which uses multi-value returns by default. This means that the generated WASM and JS code will be different in all tests now. |
14 tasks
This was referenced Oct 25, 2024
daxpedda
approved these changes
Oct 31, 2024
Member
daxpedda
left a comment
There was a problem hiding this comment.
Yes, we should probably read out the ValueType, but this is already a bug, so this doesn't degrade the current state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4207
Arrayitself is not a valid type because it requires one generic parameter. I replaced it withnumber[]. I chosenumberas the element type, because that's what the surrounding code is using for everything.Using
numberfor everything is probably wrong, since WASM usesbigintfor 64-bit ints AFAIK, but it shouldn't matter too much.