Replace lazy_static with once_cell#2962
Merged
ranile merged 2 commits intowasm-bindgen:mainfrom Jun 23, 2022
Merged
Conversation
ranile
approved these changes
Jun 23, 2022
Contributor
ranile
left a comment
There was a problem hiding this comment.
Looks good 👍. Thanks for the PR
lopopolo
added a commit
to artichoke/rust-onig
that referenced
this pull request
Aug 6, 2022
`onig` is the only dependency left in Artichoke's `Cargo.lock` that uses `lazy_static`. It looks like most of the ecosystem has moved to `once_cell`. `once_cell` looks to be more actively maintained and is IMO nicer to read since there are no macros. See also this related change in `wasm-bindgen`: - wasm-bindgen/wasm-bindgen#2962 `once_cell`'s MSRV is documented to be 1.36.0: https://github.com/matklad/once_cell/blob/eda22cec55e9d37b16d408b7d0a5b396c7feb44c/CHANGELOG.md#151
This was referenced Aug 6, 2022
iwillspeak
pushed a commit
to rust-onig/rust-onig
that referenced
this pull request
Aug 7, 2022
`onig` is the only dependency left in Artichoke's `Cargo.lock` that uses `lazy_static`. It looks like most of the ecosystem has moved to `once_cell`. `once_cell` looks to be more actively maintained and is IMO nicer to read since there are no macros. See also this related change in `wasm-bindgen`: - wasm-bindgen/wasm-bindgen#2962 `once_cell`'s MSRV is documented to be 1.36.0: https://github.com/matklad/once_cell/blob/eda22cec55e9d37b16d408b7d0a5b396c7feb44c/CHANGELOG.md#151
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… and another drive-by improvement.
Nicer to read because it isn't a macro, and most of the Rust ecosystem has switched over already.