chore: add support for protobuf v6#9612
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9612 +/- ##
==========================================
- Coverage 80.43% 80.31% -0.12%
==========================================
Files 781 781
Lines 81264 81264
==========================================
- Hits 65364 65269 -95
- Misses 15175 15266 +91
- Partials 725 729 +4
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
kptkin
approved these changes
Apr 18, 2025
dmitryduev
added a commit
that referenced
this pull request
Apr 18, 2025
This reverts commit 191275f.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Protobuf v6 is out, however grpcio-tools does not support it yet in a stable version, so this is using an rc. However, some people are already using v6, so I think we should merge this as is and re-run once stable grpcio(-tools) is out.
Testing
How was this PR tested?