fix(artifacts): raise on unsupported +Infinity/-Infinity values in artifact metadata#10845
Merged
tonyyli-wandb merged 2 commits intomainfrom Nov 7, 2025
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
matthoare117-wandb
approved these changes
Nov 7, 2025
dmitryduev
approved these changes
Nov 7, 2025
dee602a to
c43f787
Compare
ddbb93f to
14215b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Raises a
ValueErroron attempting to assign a dict toArtifact.metadatathat contains infinite values, or on attempting to log anArtifactwith such metadata values.Infinite values will serialize to JS-compatible
+Infinity/-Infinityconstants, but these do not currently play well with Go's standard json encoder/decoder. For now, raising a defensive client-sideValueErroris preferable to a response timeout.Note that
NaNvalues are allowed, as prior behavior already serializes them tonull.Testing
How was this PR tested?