fix: correct length on artifact.files#10796
Merged
matthoare117-wandb merged 24 commits intomainfrom Oct 30, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
tonyyli-wandb
approved these changes
Oct 30, 2025
Contributor
tonyyli-wandb
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix! Also thanks for navigating + rolling with what definitely turned out to be a more involved / complicated set of changes than expected 🙂
timoffex
reviewed
Oct 30, 2025
timoffex
approved these changes
Oct 30, 2025
1 task
tonyyli-wandb
added a commit
that referenced
this pull request
Jan 2, 2026
…11123) Description ----------- - Fixes https://wandb.atlassian.net/browse/WB-30038 Removes the legacy server compatibility check for the `File.storagePath` field. These server versions are long past EOL (current EOL at the time of writing is 0.63.0). As we no longer officially support the affected server versions, it's reasonable for newer SDK releases to drop the outdated workaround logic. - Remove the check for server support for the `storagePath` field (i.e. the `if client.version_supported("0.12.21")...` guard from `ArtifactFiles.__init__()`) - Simplify `omit_fields` logic to only handle `totalCount` (which was added more recently, see #10796) - Remove system test (`test_artifact_files_on_legacy_local_install`) which explicitly mocked and tested against said legacy server behavior - [x] I updated CHANGELOG.unreleased.md, or it's not applicable Testing ------- Existing tests. No behavior changes for supported server versions.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What does the PR do? Include a concise description of the PR contents.
Fixes a bug where
len(artifact.files(names=[...]))incorrectly returns the total number of files in the artifact instead of respecting thenamesfilter.Problem: When calling
artifact.files()with anamesparameter, thelen()function ignores the filter and returns the total artifact file count.Example:
Fix: Updated the
ArtifactFilesclass to correctly respect thenamesfilter when calculating length. Nowlen()returns the count of files matching the provided filter.Testing
How was this PR tested?
Added the test
test_artifacts_files_name