fix(artifacts): Api.artifact_exists and Api.artifact_collection_exists should raise on timeout errors#10591
Merged
tonyyli-wandb merged 2 commits intomainfrom Sep 26, 2025
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
352799b to
1710ed7
Compare
pingleiwandb
approved these changes
Sep 26, 2025
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
1710ed7 to
19e3819
Compare
Api.artifact_exists and Api.artifact_collection_exists should raise on timeout errors
timoffex
approved these changes
Sep 26, 2025
19e3819 to
e1a19ed
Compare
tonyyli-wandb
commented
Sep 26, 2025
…ld raise on timeout errors
e1a19ed to
1ba09d4
Compare
57d3d24 to
8640d04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Api.artifact_exists()andApi.artifact_collection_exists()should raise on timeout errors, rather than (potentially erroneously) returningFalse.Testing
How was this PR tested?