Skip to content

fix (darwin/v3) can't minimise in frameless#5016

Merged
leaanthony merged 2 commits into
wailsapp:v3-alphafrom
XljBear:v3-alpha-bugfix/issues-4294
Feb 26, 2026
Merged

fix (darwin/v3) can't minimise in frameless#5016
leaanthony merged 2 commits into
wailsapp:v3-alphafrom
XljBear:v3-alpha-bugfix/issues-4294

Conversation

@XljBear

@XljBear XljBear commented Feb 24, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Fixed the issue of frameless windows not being minimized on macOS.
#4294

Summary by CodeRabbit

  • Bug Fixes
    • Restored the ability to minimize frameless windows on macOS, so frameless windows can be minimized as expected.
  • Documentation
    • Added an unreleased changelog entry noting the fix for frameless window minimization.

@coderabbitai

coderabbitai Bot commented Feb 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ccd38b1 and 78c1fb3.

📒 Files selected for processing (1)
  • v3/UNRELEASED_CHANGELOG.md
✅ Files skipped from review due to trivial changes (1)
  • v3/UNRELEASED_CHANGELOG.md

Walkthrough

Restore minimizability for frameless macOS windows by adding NSWindowStyleMaskMiniaturizable to the frameless styleMask on Darwin.

Changes

Cohort / File(s) Summary
macOS frameless window change
v3/pkg/application/webview_window_darwin.go		 Add NSWindowStyleMaskMiniaturizable to the frameless window styleMask so frameless windows can be minimized.
Changelog update
v3/UNRELEASED_CHANGELOG.md		 Add entry: "Fix frameless window cannot be minimized on darwin (#4294)".
Module file
go.mod		 Small dependency/manifest line change (1 line modified).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

Bug, Documentation, v3, MacOS, v3-alpha, size:XS, lgtm

Suggested reviewers

  • leaanthony

Poem

🐰 A window without a frame, so neat,
Lost its shrink with a tiny feat.
One line on Darwin, a gentle nudge,
Now it hops down — a perfect judge. ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is incomplete and does not follow the required template, missing key sections like Type of change, How Has This Been Tested, Test Configuration, and Checklist items. Complete the PR description by filling in all required template sections including the Type of change checkbox, testing details, and checklist items.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: fixing the inability to minimize frameless windows on macOS (darwin).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@XljBear XljBear changed the title fix v3 can't minimise in frameless fix v3 macos can't minimise in frameless Feb 24, 2026
@XljBear XljBear changed the title fix v3 macos can't minimise in frameless fix (darwin/v3) can't minimise in frameless Feb 24, 2026
@leaanthony

leaanthony commented Feb 25, 2026

Copy link
Copy Markdown
Member

Thanks for this fix! 🙏

Before we merge, could you update the Unreleased changelog? The v3-alpha branch uses wails/v3/UNRELEASED_CHANGELOG.md — that's what triggers the nightly release workflow.

Once you've added an entry there, I can approve this PR.

@XljBear

XljBear commented Feb 25, 2026

Copy link
Copy Markdown
Contributor Author

Updated UNRELEASED_CHANGELOG

@XljBear

XljBear commented Feb 25, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for this fix! 🙏

Before we merge, could you update the Unreleased changelog? The v3-alpha branch uses wails/v3/UNRELEASED_CHANGELOG.md — that's what triggers the nightly release workflow.

Once you've added an entry there, I can approve this PR.

Thanks for this fix! 🙏

Before we merge, could you update the Unreleased changelog? The v3-alpha branch uses wails/v3/UNRELEASED_CHANGELOG.md — that's what triggers the nightly release workflow.

Once you've added an entry there, I can approve this PR.

@XljBear XljBear closed this Feb 25, 2026
@XljBear XljBear reopened this Feb 25, 2026
@leaanthony leaanthony enabled auto-merge (squash) February 25, 2026 20:06
@leaanthony leaanthony merged commit 6ad671f into wailsapp:v3-alpha Feb 26, 2026
62 of 63 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Feb 28, 2026
Open
15 tasks
@wayneforrest wayneforrest mentioned this pull request Apr 2, 2026
Merged
15 tasks
leaanthony pushed a commit that referenced this pull request Apr 16, 2026
@wayneforrest
Fixes #5016 - Fix deadlock in EventIPCTransport.DispatchWailsEvent ho…
5aa71e1 
…lding RLock during InvokeSync (#5107)

* Fix deadlock in EventIPCTransport.DispatchWailsEvent holding RLock during InvokeSync

* Update changelog

* Guard WebviewWindow.DispatchWailsEvent against destroyed windows
Grantmartin2002 pushed a commit to Grantmartin2002/wails that referenced this pull request Apr 29, 2026
@XljBear
fix (darwin/v3) can't minimise in frameless (wailsapp#5016)
0a0aaa4 
* fix v3 can't minimise in frameless

* update UNRELEASED_CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leaanthony leaanthony leaanthony approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@XljBear @leaanthony