Skip to content

[v3] fix linux .desktop file appicon variable#4477

Merged
leaanthony merged 4 commits into
wailsapp:v3-alphafrom
COD3HUNT3R:patch-2
Aug 6, 2025
Merged

[v3] fix linux .desktop file appicon variable#4477
leaanthony merged 4 commits into
wailsapp:v3-alphafrom
COD3HUNT3R:patch-2

Conversation

@COD3HUNT3R

@COD3HUNT3R COD3HUNT3R commented Aug 5, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

nfpm dst file is /usr/share/icons/hicolor/128x128/apps/{{.BinaryName}}.png but in .desktop file generation ICON variable is appicon which generates incorrect .desktop file not showing icon.

wails/v3/internal/commands/updatable_build_assets/linux/nfpm/nfpm.yaml.tmpl

Line 23 in 1cf9042

dst: "/usr/share/icons/hicolor/128x128/apps/{{.BinaryName}}.png"

Summary by CodeRabbit

  • Bug Fixes
    • Corrected the application icon reference in Linux desktop files to dynamically reflect the app name.

@coderabbitai

coderabbitai Bot commented Aug 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The update modifies the generate:dotdesktop task in the Linux Taskfile by changing the ICON variable from a static value to a dynamic one that references the application name. No changes were made to exported or public entities. Additionally, a bug fix entry was added to the unreleased changelog documenting this change.

Changes

Cohort / File(s) Change Summary
Linux Taskfile Variable Update
v3/internal/commands/build_assets/linux/Taskfile.yml		 Changed ICON in generate:dotdesktop from 'appicon' to {{.APP_NAME}} for dynamic icon naming.
Changelog Update
v3/UNRELEASED_CHANGELOG.md		 Added a bug fix entry documenting the fix for the Linux .desktop file icon variable in the Taskfile.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • leaanthony

Poem

A bunny hopped through YAML fields,
Where icons once were set and sealed.
Now names can change with nimble grace,
Each app displays its proper face.
With every build, the rabbits cheer—
Dynamic icons, crystal clear!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f8bb0f4 and c891a06.

📒 Files selected for processing (1)
  • v3/UNRELEASED_CHANGELOG.md (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • v3/UNRELEASED_CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: semgrep-cloud-platform/scan
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 5, 2025
@dosubot dosubot Bot added Bug Something isn't working Linux labels Aug 5, 2025
@COD3HUNT3R

COD3HUNT3R commented Aug 5, 2025

Copy link
Copy Markdown
Contributor Author

Thanks for another almost bogus codereview @coderabbitai. I am not going to train you with correct context.

@coderabbitai

coderabbitai Bot commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

Tip

For best results, initiate chat on the files or code changes.

@COD3HUNT3R I understand your frustration with my review, and I respect your decision not to provide additional context. I apologize if my analysis missed important details or didn't align with your expectations for this PR.

    /|   /|  
   ( :v:  )
    |(_)|

@leaanthony

leaanthony commented Aug 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Thanks for this 🙏 Please could you add an entry to the changelog located at v3/UNRELEASED_CHANGELOG.mdx? Thanks!

@github-actions github-actions Bot added the Documentation Improvements or additions to documentation label Aug 5, 2025
@sonarqubecloud

sonarqubecloud Bot commented Aug 6, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@leaanthony leaanthony enabled auto-merge (squash) August 6, 2025 11:58
@leaanthony leaanthony disabled auto-merge August 6, 2025 12:03
@leaanthony leaanthony merged commit b3c01f4 into wailsapp:v3-alpha Aug 6, 2025
13 checks passed
@leaanthony

leaanthony commented Aug 6, 2025

Copy link
Copy Markdown
Member

Thanks @COD3HUNT3R 🙏

@coderabbitai coderabbitai Bot mentioned this pull request Oct 11, 2025
Closed
15 tasks
@COD3HUNT3R COD3HUNT3R mentioned this pull request Oct 13, 2025
Closed
@coderabbitai coderabbitai Bot mentioned this pull request Oct 13, 2025
Merged
@COD3HUNT3R COD3HUNT3R deleted the patch-2 branch October 21, 2025 22:59
@coderabbitai coderabbitai Bot mentioned this pull request Dec 13, 2025
Merged
Grantmartin2002 pushed a commit to Grantmartin2002/wails that referenced this pull request Apr 29, 2026
@COD3HUNT3R @leaanthony
[v3] fix linux .desktop file appicon variable (wailsapp#4477)
5d20466 
* [v3] fix linux .desktop file appicon variable

* Update UNRELEASED_CHANGELOG.md

---------

Co-authored-by: Lea Anthony <lea.anthony@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Bug Something isn't working cli Documentation Improvements or additions to documentation Linux size:XS This PR changes 0-9 lines, ignoring generated files. v3-alpha

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@COD3HUNT3R @leaanthony