[v3 Darwin] Fix NewEditMenu, remove duplicate PasteAndMatchStyle item#3839
Conversation
WalkthroughThe changes involve the Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
Thanks 🙏 Please could you add an entry to the changelog located at |
44cf52f to
43320ac
Compare
|
@leaanthony done. I used the single line for each change format as used in the rest of the doc, and updated the other fix entry to match. |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
mkdocs-website/docs/en/changelog.md (1)
26-27: LGTM! Consider a minor improvement.The new changelog entries are well-formatted and provide clear information about the fixes. They align with the project's changelog structure and properly credit the contributors.
The entry on line 27 accurately reflects the PR objective of removing the duplicate
PasteAndMatchStyleitem from the Edit menu on Darwin systems.Consider changing "Daemin" to "Darwin" on line 27 to correct the typo:
-- [darwin] Fixed `application.NewEditMenu` including a duplicate `PasteAndMatchStyle` role in the edit menu on Daemin by [johnmccabe](https://github.com/johnmccabe) in [#3839](https://github.com/wailsapp/wails/pull/3839) ++ [darwin] Fixed `application.NewEditMenu` including a duplicate `PasteAndMatchStyle` role in the edit menu on Darwin by [johnmccabe](https://github.com/johnmccabe) in [#3839](https://github.com/wailsapp/wails/pull/3839)
43320ac to
2f4d6e4
Compare
|
Fixed typo flagged by CodeRabbitAI and repushed the commit |
|
…wailsapp#3839) * [V3 Darwin] Fix NewEditMenu, remove duplicate PasteAndMatchStyle item * [chore] Add darwin fix for NewEditMenu dupe role to changelog - PR wailsapp#3839 --------- Co-authored-by: Lea Anthony <lea.anthony@gmail.com>
Description
What looks to be a simple copy paste error in the V3
application.NewEditMenu()function where thePasteAndMatchStylerole in the Edit menu has been duplicated. Noticed when running the V3 examples and having ported a personal app across.Given the trivial nature of the change I've skipped the issue creation, can swing back and create if you wish.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Running the V3 binding example before and after the change to confirm the presence and then absence of the duplicated menu item. Change is within a
darwinonly conditional so I've skipped Windows and Linux validation.Test Configuration
Freshly checked out
v3-alphabranch on MacOS14.7, Go1.23.2.Checklist:
website/src/pages/changelog.mdxwith details of this PR. I skipped this as there doesn't seem to be any other entries for V3 prior to its release.Summary by CodeRabbit
Bug Fixes
AlwaysOnTopfunctionality on macOS.New Features
These changes improve the user experience by ensuring a more streamlined menu interface on macOS and enhancing support across various platforms.