[v3] actions improvements & run actions on more branches and in forks by stendler · Pull Request #3747 · wailsapp/wails

stendler · 2024-09-14T17:01:46Z

Description

update used actions to use newer node 20 and get rid of warnings
don't fail fast in OS matrix to allow seeing if only one system is affected
also run build-and-test-alpha on branches prefixed with v3/ or v3-
enable to run in forks to make testing easier (no quota for public repos)
add cache dependency path for setup-go to enable caching (and get rid of the warning, that no go.sum was found in the project root)

Type of change

CI / actions

How Has This Been Tested?

As part of the actions in my fork: https://github.com/stendler/wails/actions

Checklist:

I have updated website/src/pages/changelog.mdx with details of this PR
I have performed a self-review of my own code

Summary by CodeRabbit

Chores
- Enhanced build and testing processes in the CI/CD pipeline.
- Expanded workflow triggers to include more branch patterns.
- Updated various actions to their latest versions for improved performance and efficiency.
- Changed the fail-fast strategy to allow all jobs to run to completion, enhancing visibility of test results.
- Improved Events API with clearer event handling methods and fixes for better functionality.

coderabbitai · 2024-09-14T17:01:54Z

Walkthrough

The GitHub Actions workflow file .github/workflows/build-and-test-alpha.yml has been updated to enhance the build and testing processes. The trigger conditions have been expanded to include additional branch patterns. Several actions used in the workflow have been upgraded to their latest versions to improve dependency management and caching efficiency. Additionally, the fail-fast strategy has been modified to allow all jobs to run to completion, providing better visibility into test results.

Changes

File	Change Summary
`.github/workflows/build-and-test-alpha.yml`	- Expanded workflow triggers to include branches `v3/` and `v3-`. - Updated actions to latest versions: `actions/checkout` from v3 to v4, `actions/setup-go` from v3 to v5, `arduino/setup-task` from v1 to v2, `actions/setup-node` from v3 to v4, `actions/cache` from v3 to v4. - Changed `fail-fast` strategy from `true` to `false` for `test_go` and `test_js` jobs.
`mkdocs-website/docs/en/changelog.md`	- Updated Events API with method renaming for better event handling. - Fixed Linux-specific issue in Events API. - Enhanced CI actions to run in forks and branches prefixed with `v3/` or `v3-`. - Resolved bug in `customEventProcessor` for drag-and-drop example.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant GitHub Actions
    participant Build System
    participant Test System

    User->>GitHub Actions: Push code to branch
    GitHub Actions->>Build System: Trigger build
    Build System->>GitHub Actions: Build completed
    GitHub Actions->>Test System: Run tests
    Test System-->>GitHub Actions: Tests results
    GitHub Actions-->>User: Notify results

Poem

🐰 In the meadow where code does play,
Upgraded actions brighten the day.
Branches now dance in a wider array,
With tests that run, come what may!
Hops of joy in the CI flow,
Let’s build and test, watch our project grow! 🌼

Tip

OpenAI O1 model for chat

We have deployed OpenAI's latest O1 model for chat.
OpenAI claims that this model has superior reasoning capabilities than their GPT-4o model.
Please share any feedback with us in the discussions post.

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d3dbda8 and 363c24f.

Files selected for processing (2)

.github/workflows/build-and-test-alpha.yml (4 hunks)
mkdocs-website/docs/en/changelog.md (1 hunks)

Files skipped from review as they are similar to previous changes (1)

.github/workflows/build-and-test-alpha.yml

Additional comments not posted (1)

mkdocs-website/docs/en/changelog.md (1)

27-27: CI improvements enhance development flexibility.

The changes to the CI actions, allowing them to run in forks and branches prefixed with v3/ or v3-, are a valuable improvement to the development process. This flexibility enables easier testing and collaboration without the limitations of public repositories.

Great work on this enhancement! It streamlines the workflow and benefits all contributors.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

leaanthony · 2024-09-14T20:47:22Z

Thanks for taking the time to do this - it was due some TLC🙏

Please could you add an entry to the changelog located at mkdocs-website/docs/changelog.md? Thanks!

to get rid of warnings

sonarqubecloud · 2024-09-14T21:08:16Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

stendler · 2024-09-14T21:10:57Z

@leaanthony I wasn't sure, if this change was worthy of an entry, as it changed nothing in wails per se. I've added one now!

leaanthony · 2024-09-14T21:14:35Z

Really appreciate this 🙏

leaanthony · 2024-09-14T21:17:12Z

@leaanthony I wasn't sure, if this change was worthy of an entry, as it changed nothing in wails per se. I've added one now!

Of course! The project is more than just code and we appreciate all efforts to improve the project as a whole 🙏

…wailsapp#3747) * [v3] actions: run in forks and also build v3/* or v3-* branches * [v3] actions: don't fail fast in test build actions * [v3] actions: update actions to node20 * [v3] actions: specify cache dependency path for setup-go to get rid of warnings

stendler added 3 commits September 14, 2024 16:53

[v3] actions: run in forks and also build v3/* or v3-* branches

57286f1

[v3] actions: don't fail fast in test build actions

6648ee0

[v3] actions: update actions to node20

107bfb7

[v3] actions: specify cache dependency path for setup-go

363c24f

to get rid of warnings

stendler force-pushed the v3/actions branch from d3dbda8 to 363c24f Compare September 14, 2024 21:07

leaanthony approved these changes Sep 14, 2024

View reviewed changes

leaanthony merged commit 56494d8 into wailsapp:v3-alpha Sep 14, 2024

coderabbitai Bot mentioned this pull request Nov 6, 2024

Fixed typo #3846

Merged

AkshayKalose mentioned this pull request Jan 3, 2025

[v3] Update Templates (macOS Target Version and Linux aarch64 AppImage) #3981

Merged

coderabbitai Bot mentioned this pull request Feb 17, 2025

[v3] Late service registration and error handling overhaul #4066

Merged

15 tasks

coderabbitai Bot mentioned this pull request Feb 25, 2025

[v3] TypeScript runtime #4100

Merged

15 tasks

github-actions Bot mentioned this pull request Jul 13, 2025

[V3] fix: enhance doctor command to verify Windows SDK dependencies #4392

Merged

15 tasks

coderabbitai Bot mentioned this pull request Nov 9, 2025

chore(docs): update dependencies and improve documentation formatting #4699

Open

1 task

This was referenced Apr 14, 2026

ci: speed up GitHub Actions workflows #5149

Merged

ci: upgrade outdated actions and cache deps in PR Checks (master) #5150

Merged

coderabbitai Bot mentioned this pull request Apr 29, 2026

chore(workflows): audit — add path filters, drop dead workflows #5280

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[v3] actions improvements & run actions on more branches and in forks#3747

[v3] actions improvements & run actions on more branches and in forks#3747
leaanthony merged 4 commits into
wailsapp:v3-alphafrom
stendler:v3/actions

stendler commented Sep 14, 2024 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Sep 14, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

leaanthony commented Sep 14, 2024

Uh oh!

sonarqubecloud Bot commented Sep 14, 2024

Uh oh!

stendler commented Sep 14, 2024

Uh oh!

leaanthony commented Sep 14, 2024

Uh oh!

leaanthony commented Sep 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

stendler commented Sep 14, 2024 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

How Has This Been Tested?

Checklist:

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Sep 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

leaanthony commented Sep 14, 2024

Uh oh!

sonarqubecloud Bot commented Sep 14, 2024

Quality Gate passed

Uh oh!

stendler commented Sep 14, 2024

Uh oh!

leaanthony commented Sep 14, 2024

Uh oh!

leaanthony commented Sep 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

stendler commented Sep 14, 2024 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Sep 14, 2024 •

edited

Loading