Skip to content

[linux] fix: update for new events syntax#3734

Merged
leaanthony merged 1 commit into
wailsapp:v3-alphafrom
TheGB0077:v3-alpha
Sep 8, 2024
Merged

[linux] fix: update for new events syntax#3734
leaanthony merged 1 commit into
wailsapp:v3-alphafrom
TheGB0077:v3-alpha

Conversation

@TheGB0077

@TheGB0077 TheGB0077 commented Sep 8, 2024 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Changed uses of deprecated .On to the current standard.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I updated to the latest v3-alpha, containing the refactor to Events and then tried to build my Application, after said issues I found those to be the blockers to my compilation.

  • Linux

Checklist:

  • I have updated website/src/pages/changelog.mdx with details of this PR
  • My code follows the general coding style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Summary by CodeRabbit

  • New Features

    • Enhanced event handling for application startup and window state changes, providing a more streamlined interface for managing events.

  • Bug Fixes

    • Improved specificity in event registration methods, which may lead to better event management and processing.

  • Refactor

    • Updated method names for clarity and consistency in event handling across the application.

@TheGB0077
[linux] fix: update for new events syntax
7607d19 
Changed uses of deprecated `.On` to the current standard.
@coderabbitai

coderabbitai Bot commented Sep 8, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The pull request introduces modifications to the event handling mechanisms in the Linux application framework. Key changes include the renaming of methods used for registering application and window events, which shifts from a general On method to more specific methods like OnApplicationEvent and OnWindowEvent. These changes are applied across multiple files, including application_linux.go, events_common_linux.go, and webview_window_linux.go. The alterations aim to refine the event registration process, enhancing the clarity and specificity of how events are handled within the application. While the overall control flow remains unchanged, the new method names suggest a more organized approach to event management, potentially improving the maintainability of the code.

Changes

File Path Change Summary
v3/pkg/application/application_linux.go Changed event registration from On to OnApplicationEvent for ApplicationStartup.
v3/pkg/application/events_common_linux.go Replaced a.parent.On with a.parent.OnApplicationEvent in setupCommonEvents function.
v3/pkg/application/webview_window_linux.go Replaced On with OnWindowEvent for various window-related events (e.g., WindowLoadChanged, WindowFocusIn, etc.).

Poem

In the code where events do play,
A rabbit hops and sings today.
With clearer paths for events to flow,
Our Linux app is set to grow!
Hooray for changes, bright and new,
Let’s hop along, there’s much to do! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sonarqubecloud

sonarqubecloud Bot commented Sep 8, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

coderabbitai[bot]
coderabbitai Bot reviewed Sep 8, 2024
View reviewed changes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5cde12b and 7607d19.

Files selected for processing (3)
  • v3/pkg/application/application_linux.go (1 hunks)
  • v3/pkg/application/events_common_linux.go (1 hunks)
  • v3/pkg/application/webview_window_linux.go (2 hunks)
Additional comments not posted (8)
v3/pkg/application/events_common_linux.go (1)

16-16: Approved: Updated event registration method.

The change from a.parent.On to a.parent.OnApplicationEvent aligns with the new event handling standards. It's recommended to add a comment explaining why this change was necessary for future maintainability.

v3/pkg/application/application_linux.go (1)

97-97: Approved: Updated event registration method.

The change from a.parent.On to a.parent.OnApplicationEvent aligns with the new event handling standards. It's recommended to add a comment explaining why this change was necessary for future maintainability.

v3/pkg/application/webview_window_linux.go (6)

292-292: Approved: Updated event registration method for window load changes.

The change from On to OnWindowEvent aligns with the new event handling standards. It's recommended to add a comment explaining why this change was necessary for future maintainability.

301-301: Approved: Updated event registration method for window focus in events.

The change from On to OnWindowEvent aligns with the new event handling standards. It's recommended to add a comment explaining why this change was necessary for future maintainability.

304-304: Approved: Updated event registration method for window focus out events.

The change from On to OnWindowEvent aligns with the new event handling standards. It's recommended to add a comment explaining why this change was necessary for future maintainability.

307-307: Approved: Updated event registration method for window delete events.

The change from On to OnWindowEvent aligns with the new event handling standards. It's recommended to add a comment explaining why this change was necessary for future maintainability.

310-310: Approved: Updated event registration method for window move events.

The change from On to OnWindowEvent aligns with the new event handling standards. It's recommended to add a comment explaining why this change was necessary for future maintainability.

313-313: Approved: Updated event registration method for window resize events.

The change from On to OnWindowEvent aligns with the new event handling standards. It's recommended to add a comment explaining why this change was necessary for future maintainability.

@leaanthony

leaanthony commented Sep 8, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Thanks 🙏 Please could you add an entry to the changelog located at mkdocs-website/docs/changelog.md? Thanks!

I had to do the same on Mac. Adding the credits for you

@leaanthony leaanthony merged commit 5481f3a into wailsapp:v3-alpha Sep 8, 2024
@coderabbitai coderabbitai Bot mentioned this pull request Sep 14, 2024
Closed
9 tasks
@coderabbitai coderabbitai Bot mentioned this pull request Oct 13, 2024
Merged
15 tasks
This was referenced Nov 16, 2024
Merged
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Dec 1, 2024
Merged
15 tasks
@AkshayKalose AkshayKalose mentioned this pull request Jan 3, 2025
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Jun 20, 2025
Merged
@github-actions github-actions Bot mentioned this pull request Jul 13, 2025
Merged
15 tasks
@coderabbitai coderabbitai Bot mentioned this pull request Dec 13, 2025
Merged
4 tasks
@coderabbitai coderabbitai Bot mentioned this pull request Dec 28, 2025
Closed
Grantmartin2002 pushed a commit to Grantmartin2002/wails that referenced this pull request Apr 29, 2026
@TheGB0077
[linux] fix: update for new events syntax (wailsapp#3734)
ea77943 
Changed uses of deprecated `.On` to the current standard.
@coderabbitai coderabbitai Bot mentioned this pull request May 18, 2026
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TheGB0077 @leaanthony