Fixing compatibility errors w/Gin and Windows. by AnalogJ · Pull Request #3537 · wailsapp/wails

AnalogJ · 2024-06-14T22:01:50Z

😬 Sorry I haven't opened a issue about these yet. They've been living in my branch for more than 6months at this point, made sense to move them upstream

Description

The contentTypeSniffer struct is not compatible with the Gin response, which requires the http.CloseNotifier interface.
Fixing a parsing error for syso options.

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration using wails doctor.

Windows
macOS

Test Configuration


                                
          Wails Doctor          
                                

                                                                                                                                                                            
# System
┌──────────────────────────────┐
| Name          | MacOS        |
| Version       | 12.6         |
| ID            | 21G115       |
| Branding      | Monterey     |
| Platform      | darwin       |
| Architecture  | arm64        |
| Apple Silicon | true         |
| CPU           | Apple M1 Max |
| CPU           | Unknown      |
| GPU           | Unknown      |
| Memory        | Unknown      |
└──────────────────────────────┘

# Build Environment
┌─────────────────────────────────────────────────────────┐
| Wails CLI    | v3.0.0-alpha.4                           |
| Go Version   | go1.22.4                                 |
| Revision     | ab06920e74473cb0e34bf2dfffdd8bda023f3ddc |
| Modified     | false                                    |
| -buildmode   | exe                                      |
| -compiler    | gc                                       |
| CGO_CFLAGS   |                                          |
| CGO_CPPFLAGS |                                          |
| CGO_CXXFLAGS |                                          |
| CGO_ENABLED  | 1                                        |
| CGO_LDFLAGS  |                                          |
| GOARCH       | arm64                                    |
| GOOS         | darwin                                   |
| vcs          | git                                      |
| vcs.modified | false                                    |
| vcs.revision | ab06920e74473cb0e34bf2dfffdd8bda023f3ddc |
| vcs.time     | 2024-06-08T22:28:38Z                     |
└─────────────────────────────────────────────────────────┘

# Dependencies
┌────────────────────────────────────────────────────────────────────────┐
| Xcode cli tools | 2395                                                 |
| npm             | 10.5.0                                               |
| *NSIS           | Not Installed. Install with `brew install makensis`. |
└─────────────────────── * - Optional Dependency ────────────────────────┘

# Diagnosis
 SUCCESS  Your system is ready for Wails development!

Checklist:

I have updated website/src/pages/changelog.mdx with details of this PR
My code follows the general coding style of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes

…ontentTypeSniffer, for Gin (and other framework) compatibility.

leaanthony · 2024-06-14T23:07:40Z

Thanks for doing this. What's the parsing error?

AnalogJ · 2024-06-15T05:00:42Z

honestly, I don't even know any more. The http.CloseNotifier interface is still an issue, but I'm not quite sure why those syso changes were required.

It must be related to my generate command, but I'm not sure.

wails3 generate syso -arch {{.ARCH}} -icon icon.ico -manifest wails.exe.manifest -info info.json -out ../wails.syso

leaanthony · 2024-06-15T10:53:39Z

Are you ok if we take out the syso change? That line currently works fine in the default template.
Please could you also add an entry to the changelog located at mkdocs-website/docs/changelog.md?
Do you have a publicly sharable example of the gin integration you are doing? Would love to write a guide on it 🙏

AnalogJ · 2024-06-15T15:24:38Z

Done! ✅

removed the syso changes
Changelog entry

Do you have a publicly sharable example of the gin integration you are doing? Would love to write a guide on it 🙏

Unfortunately I don't, my desktop app is the paid version of my open-source fasten-onprem project.

But it's mostly just some custom setup and then calling:

	app := application.New(application.Options{
		Assets: application.AssetOptions{
			Middleware: FileServerMiddleware,
			Handler:    ginWebServerEngine.Handler(),
		},
		...
	}

therealsamf · 2024-08-27T21:11:36Z

Is this still in progress? I ran into same issue using echo and contentTypeSniffer not implementing http.Flusher interface.

The app panics here: https://github.com/labstack/echo/blob/master/response.go#L91

This is for echo & possibly other golang backend framework compatiblity. See wailsapp#3537

leaanthony · 2024-11-17T09:54:25Z

@therealsamf - Are you able to test this PR and confirm it works for your use case?

coderabbitai · 2024-11-17T10:10:16Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

therealsamf · 2024-11-28T18:25:30Z

@therealsamf - Are you able to test this PR and confirm it works for your use case?

I tested a portion of it and can confirm it works.

leaanthony · 2025-03-11T10:14:06Z

Hey @AnalogJ! Finally got round to looking at this and found that there a few things to tidy up but couldn't push to your PR branch so I've opened this PR based on your work here and credited you in the docs.

I'd appreciate it if you could take a look and see if you have any feedback. Thank you 🙏

adding http.CloseNotifier and http.Flusher interface to assetserver.c…

aa58218

…ontentTypeSniffer, for Gin (and other framework) compatibility.

AnalogJ force-pushed the v3-alpha-analog-v2 branch from 80a4532 to aa58218 Compare June 15, 2024 15:16

update changelog.

08a00a7

therealsamf added a commit to therealsamf/wails that referenced this pull request Aug 29, 2024

Add http.Flusher interface to assetserver.contentTypeSniffer

a8f7fd3

This is for echo & possibly other golang backend framework compatiblity. See wailsapp#3537

leaanthony added the awaiting feedback More information is required from the requestor label Nov 17, 2024

leaanthony mentioned this pull request Mar 11, 2025

Gin support #4128

Merged

leaanthony closed this Mar 11, 2025

github-actions Bot mentioned this pull request Jul 13, 2025

[V3] fix: enhance doctor command to verify Windows SDK dependencies #4392

Merged

15 tasks

renovate Bot mentioned this pull request Jul 13, 2025

fix(deps): update module github.com/wailsapp/wails/v3 to v3.0.0-alpha.51 autocord-org/dmg#388

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fixing compatibility errors w/Gin and Windows.#3537

Fixing compatibility errors w/Gin and Windows.#3537
AnalogJ wants to merge 2 commits into
wailsapp:v3-alphafrom
fastenhealth:v3-alpha-analog-v2

AnalogJ commented Jun 14, 2024 •

edited

Loading

Uh oh!

leaanthony commented Jun 14, 2024

Uh oh!

AnalogJ commented Jun 15, 2024

Uh oh!

leaanthony commented Jun 15, 2024 •

edited

Loading

Uh oh!

AnalogJ commented Jun 15, 2024 •

edited

Loading

Uh oh!

therealsamf commented Aug 27, 2024

Uh oh!

leaanthony commented Nov 17, 2024

Uh oh!

coderabbitai Bot commented Nov 17, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

therealsamf commented Nov 28, 2024

Uh oh!

leaanthony commented Mar 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

AnalogJ commented Jun 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

How Has This Been Tested?

Test Configuration

Checklist:

Uh oh!

leaanthony commented Jun 14, 2024

Uh oh!

AnalogJ commented Jun 15, 2024

Uh oh!

leaanthony commented Jun 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AnalogJ commented Jun 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

therealsamf commented Aug 27, 2024

Uh oh!

leaanthony commented Nov 17, 2024

Uh oh!

coderabbitai Bot commented Nov 17, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

therealsamf commented Nov 28, 2024

Uh oh!

leaanthony commented Mar 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AnalogJ commented Jun 14, 2024 •

edited

Loading

leaanthony commented Jun 15, 2024 •

edited

Loading

AnalogJ commented Jun 15, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)