Allow Wails3 Doctor recognize globally installed apt packages#2972
Merged
Conversation
✅ Deploy Preview for dapper-pastelito-9b5e5b ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Adding a space to ensure checking against "all" doesn't always catch "install" or "not-installed" etc
Doctor Apt Verify
leaanthony
approved these changes
Oct 14, 2023
Merged
15 tasks
Grantmartin2002
pushed a commit
to Grantmartin2002/wails
that referenced
this pull request
Apr 29, 2026
…pp#2972) * Fixes doctor bug for apt package manager * Actually fix it * Pad the text " all" Adding a space to ensure checking against "all" doesn't always catch "install" or "not-installed" etc * Update changelog.md Doctor Apt Verify --------- Co-authored-by: atterpac <michael@atterpac.dev> Co-authored-by: Lea Anthony <lea.anthony@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
wails3 doctorcommand failed to recognize installed apt due to checking for "[installed]" so any packages installed both globally and locally packages are listed as "all" for example a globally installed npm would returnnpm/jammy 8.5.1~ds-1 allFixes if packages have more than one attribute "[installed, <other attributes>]" by checking if
apt list -qqreturns either "installed" or "any"Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Test Configuration
Removed required packages pkg-config and libwebkit to ensure the test still fails if no package is missing
Added removed packages per wails doctor instructions
Ran
wails3 doctorto ensure it validated the installChecklist:
website/src/pages/changelog.mdxwith details of this PR (no changed needed)