Skip to content

[v3] Fix default context-menu in selected disabled inputs#2753

Merged
leaanthony merged 2 commits into
wailsapp:v3-alphafrom
mmghv:fix/default-contextmenu-disabled-inputs
Jul 1, 2023
Merged

[v3] Fix default context-menu in selected disabled inputs#2753
leaanthony merged 2 commits into
wailsapp:v3-alphafrom
mmghv:fix/default-contextmenu-disabled-inputs

Conversation

@mmghv

@mmghv mmghv commented Jun 30, 2023

Copy link
Copy Markdown
Contributor

processDefaultContextMenu() was missing showing the default context-menu for selected text in a disabled or readonly input, this PR fixes that to be aligned with v2.

Title: "Context Menu Demo",
Width: 1024,
Height: 1124,
Height: 1024,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I set this to 1124 as all the boxes didn't fit on Windows :-) Do they all fit in Mac?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just sized it and then ran wails.Window.Size() in devtools and got this:

height: 1681,
width:1024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my screen a little bit was hidden under the windows taskbar, so made it smaller to fit and scrollbars with appear, I don't know how it looks on Mac.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah the joys of different screen resolutions 😅

@leaanthony leaanthony merged commit e419822 into wailsapp:v3-alpha Jul 1, 2023
@leaanthony

Copy link
Copy Markdown
Member

I accidentally pushed some updates to your PR branch 😅 It's all good - we can merge.

@mmghv mmghv deleted the fix/default-contextmenu-disabled-inputs branch July 1, 2023 04:27
@coderabbitai coderabbitai Bot mentioned this pull request Mar 11, 2025
Grantmartin2002 pushed a commit to Grantmartin2002/wails that referenced this pull request Apr 29, 2026
)

* [v3] Fix default context-menu in selected disabled inputs

* [v3] Update Task to v3.27.1. Add `wails3 task -version` and `wails3 task taskfile:update`.

---------

Co-authored-by: Lea Anthony <lea.anthony@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants