Fix copy-paste between editors losing formatting/content #4432#4582
Merged
gasman merged 1 commit intowagtail:masterfrom Jun 14, 2018
Merged
Conversation
…formatting/content. Fixes wagtail#4432
This was referenced Jun 5, 2018
Member
Author
|
🎉 |
thibaudcolas
added a commit
to thibaudcolas/wagtail
that referenced
this pull request
Jul 9, 2018
thibaudcolas
added a commit
that referenced
this pull request
Jul 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4432. This pull request has been made possible by the backing of my Patreon patrons.
The current copy-paste behavior is a mixture of the browser's default copy behavior, and the Draft.js paste processing.
With this Draftail update, we now override the defaults for both copy and paste between editors:
Tested in:
This fixes quite a few of the known issues with Draft.js (#4274), see the potential diff over at springload/draftail#147 (comment). I'll update the list myself once this PR is merged.
The underlying code changes are: