Conversation
|
Quick update: Soramitsu indicated that there are a few essential calls missing, namely |
Noc2
left a comment
There was a problem hiding this comment.
Btw. the psp number should be 6 (same as PR) and feel free to change the status to draft. After this, I think we can merge it into the draft folder: https://github.com/w3f/PSPs/tree/master/PSPs/drafts This way it's easier to discuss it and others can contribute to it.
FlorianFranzen
left a comment
There was a problem hiding this comment.
If you fix the last few typos and add a proper section on websockets and pubsub, I think this should be ready to be merged.
danforbes
left a comment
There was a problem hiding this comment.
Amazing job, @lamafab 🙇 Very well-written 🎉 I did not perform an exhaustive review; just left a few nitpicky comments. I would also suggest using a formatting tool like Prettier on this in order to limit the line length...this should be enforced on this repo in general, I think, because otherwise documents can be hard to review.
|
@FlorianFranzen @danforbes Thank you for your feedback, I adjusted pretty much everything. Do note that I added a simple You can run it with: Also, my editor currently generated the table of contents, including section numbering. Maybe that's something we can do globally for all documents by using @FlorianFranzen I will update |
Updated proposal to meet ABI level specifications
(UPDATED 2020-11-25) Preview: https://github.com/w3f/PSPs/blob/psp-rpc-api/PSPs/drafts/psp-6.md
As discussed, this is a draft/WIP and will change a lot over the next days/weeks. Generally, it needs to adjust to the decisions made by Parity.
A TODO list available here: w3f/polkadot-spec#67 (comment)