Skip to content

ECDSA for Polkadot JS#6

Merged
gavofyork merged 1 commit intow3f:masterfrom
akru:master
Mar 6, 2020
Merged

ECDSA for Polkadot JS#6
gavofyork merged 1 commit intow3f:masterfrom
akru:master

Conversation

@akru
Copy link
Copy Markdown
Contributor

@akru akru commented Mar 5, 2020 •
edited
Loading

Grant Application Checklist

  • The application-template.md has been copied, renamed ( "project_name.md") and updated.
  • A BTC address for the payment of the milestones is provided inside the application.
  • The software of the project will be released under the Apache license version 2.0 as specified in the terms and conditions.
  • The total funding amount of the project is below 30k at the time of submission.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 5, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Noc2
Copy link
Copy Markdown
Contributor

Noc2 commented Mar 5, 2020

Hi akru. Thanks for the application. Could you add a little bit more details and things like (delivery) documentation as well as tests to the application? Also, we just signed a grant with nodefactory for a metamask plugin yesterday. Therefore, maybe it makes sense that you initially only focus on the first milestone. Let me know if you need any help with signing our terms via the cla assistant.

@akru
Copy link
Copy Markdown
Contributor Author

akru commented Mar 5, 2020

Hey David @Noc2,
oh, really! But I happy that it will be implemented soon.

So, I've remove milestone 2 and extend milestone 1 detailed derivations like tests and documentation with demo video. Please let me known if you have any questions.

@Noc2
Copy link
Copy Markdown
Contributor

Noc2 commented Mar 5, 2020

Thanks for integrating the changes. The table in the document currently doesn't render correctly (you probably need to remove one "|"). Apart from that, the application looks rather expensive to me and I'm not sure you actually need two weeks for this. Could you reduce the price a little bit more?

@akru akru force-pushed the master branch 2 times, most recently from 54ae6e4 to 5e33da7 Compare March 6, 2020 07:04
@akru
Copy link
Copy Markdown
Contributor Author

akru commented Mar 6, 2020 •
edited
Loading

Got it!
@Noc2 I've fix table rendering and decrease payment rate a bit to make a more comfortable price for W3F.

Noc2
Noc2 previously approved these changes Mar 6, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The table still doesn't render correctly for me, but that's not a major issue for me, so I'm happy to approve/vote for the application.

gavofyork
gavofyork previously approved these changes Mar 6, 2020
View reviewed changes
@akru akru dismissed stale reviews from gavofyork and Noc2 via baf94b3 March 6, 2020 08:36
@akru
Copy link
Copy Markdown
Contributor Author

akru commented Mar 6, 2020

Oh, yes, fixed!

Thank you so much! @Noc2 @gavofyork

@gavofyork gavofyork merged commit 712c751 into w3f:master Mar 6, 2020
Noc2 pushed a commit that referenced this pull request Nov 19, 2020
Merge pull request #6 from mmagician/testgin3
8e7d562 
testing with fixed workspace
alxs pushed a commit that referenced this pull request Jul 20, 2021
@robcxyz
Merge pull request #6 from Mitchellpkt/patch-7
1a4bbc3 
Spelling
gusiri added a commit to shopxlabs/Open-Grants-Program that referenced this pull request Aug 12, 2021
@gusiri
Update eNFT.md
12d3034 
- removed milestone w3f#1 and w3f#6
- updated development roadmap overview (from 12 months to 6 months) 
- added eNFT Reference Architecture and survey on Polkadot NFT Projects as reference (other project details section)
@tylermcwilliams tylermcwilliams mentioned this pull request May 16, 2025
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavofyork gavofyork gavofyork approved these changes

+2 more reviewers

@folsen folsen folsen approved these changes

@Noc2 Noc2 Noc2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@akru @CLAassistant @Noc2 @folsen @gavofyork