Update: Have submitted the dot_marketplace-Phase3-milestone_2 delivery as well.

Update: Submitted the final milestone dot_marketplace-Phase3-milestone_3 delivery as well.

Hi @Loaki07, thanks for the 3 deliveries, and sorry for the waiting. I'll begin the evaluations asap, and I'll reach out if I need your help.

General

Another thing: i was starting the evaluation of Milestone 2, and I've seen you delivered also a frontend in the following repo: https://github.com/WowLabz/tasking_frontend; here, I can see there is a branch named Phase3_Milestone1. Is that supposed to be evaluated, or one of the deliveries of Milestone 1?

Also, I'de remove testing_guide.md from the dot-marketplace-v2 repo, at least from the branches of these 3 milestones, as the testing guide is in the dot_marketplace_docker repo.

Finally, I'd update (or remove, as you prefer) the part Future Plans from the README.md of dot-marketplace-v2, as it's the same for each Milestone's branch (maybe just keep it in master?).

Milestone 1

Here I am @Loaki07. Before accepting the first milestone, I'd like to write the following comments/questions:

• Is it ok that a user can bid the same milestone multiple times, also if his other bid is still open?
• Have you considered/planned to make TaskTypeTags customizable/editable?
• The milestone's deadline is the number of day the milestone can last, right? So in this case M2's deadline can be < than M1's;
• Do you plan to control the rating value? For now it should be a number from 0 to 255, as now it's u8; EDIT: I've seen in milestone 2 this is checked (1<=rating<=5).
• In the videoguide, Alice manages to close the project also if the milestone 1b was still open. As I couldn't, and I only could close it if all the milestones are completed, I assume that you've seen the issue and solved it, but it was still in the video, right? In this case it's not a problem, I just want to double check.

1. We have fixed this issue for all the milestones. A bidder can now only bid once per milestone.
2. Yes, as per the clients we can modify this to include tags of their own. However, we can can also modify this to be dynamic as per request by introducing a Tag Management Model.
3. Yes, the milestones are independent of each others timelines (based on their complexity).
4. Yes, its fixed to a number between 1-5 both in the frontend and backend.
5. Yes, this was possible because all the milestone was still Open. In this case, the funds to all the bidders will be transferred back code. However, when each milestone in the project is not in either status Open or Completed the customer can't close the project. This was designed to be this way to give the customer an option to close a project that he might have added and doesn't want to proceed with it.

Another thing: i was starting the evaluation of Milestone 2, and I've seen you delivered also a frontend in the following repo: https://github.com/WowLabz/tasking_frontend; here, I can see there is a branch named Phase3_Milestone1. Is that supposed to be evaluated, or one of the deliveries of Milestone 1?

This branch was created for development sake. It is neither a delivery for Milestone 1 nor needs to be evaluated. All the changes are available along with the new features in Milestone 2 as a delivery.

Also, I'de remove testing_guide.md from the dot-marketplace-v2 repo, at least from the branches of these 3 milestones, as the testing guide is in the dot_marketplace_docker repo.

We've removed the old testing guide from all the Phase 3 branches.

Finally, I'd update (or remove, as you prefer) the part Future Plans from the README.md of dot-marketplace-v2, as it's the same for each Milestone's branch (maybe just keep it in master?).

We have modified this as per Phase 3.

Milestone 2

As for the previous milestone, both docker and without-docker setups were straightforward.

Backend comments

Everything seems to work greatly, I've just two things to say about votes:

• accept_jury_duty issue

  I've just noted an issue, but I'm not sure if it's on your end, so I'll ask here: often, when I try to cast a vote with a Potential Juror I get this error from the frontend:
  
  So I tried to reproduce it with PolkadotJS to know more about it, and it gave me the JurySelectionPeriodElapsed error. From the source code, I see that it's like the Juror has been too slow to fire the accept_jury_duty function. Is that possible, and is that a bug?

The decision to be part of the jury is 1 day (1 era) or 14_400 slots i.e. 24 hours. However, for the purpose of testing it has been set to 5 blocks source code. Once the case begins/accepted, the jurors have 2 eras (2 days) to evaluate the work done & cast their votes to either of the parties i.e. the customer or worker. However, for testing purposes the duration is for 10 blocks and only 2 Jurors can cast their votes.
I believe the error would have occurred, when 2 final Jurors have completed voting and the 3rd Juror was casting the vote.

• accept_jury_duty ratings

  (This is just a discussion to understand better the project's operations)
  I didn't get it why a Juror can, as well as choosing who they are voting for, cast their ratings for both the customer and worker. Is this to "correct" the ratings they're voting against? If yes, is it good for milestones disputes, as there are no ratings at the time a milestone is disputed? Or maybe is because a voter can express his rating in advance?

Yes, the Jurors cast the vote for both Custom & Worker to ensure fair judgement on the milestone created & submitted as it would be reviewed completely at the time of dispute. The average of all the ratings provided will then be finalized.

Frontend comments

Other than this, I didn't see any other important things in the backend, but I'd like to comment quickly the frontend (I think it should be an MVP, but maybe these could still be useful to you):

• On the login page, I’d replace User Name with Email (and not writing under the input field “Enter registered EmailID”)

On the product page we have it in this manner. We'll fix this for the milestone 3.

• On the create project page, if I try to change the wallet the frontend breaks, and then I have to logout and re-login;

We have found this issue, will fix it and let you know.

• If I try edit milestone, its cost increases each time the button gets pressed;

We have fixed this issue. For explanation, the cost remained the same only that when viewing the cost the 2nd time it was showing in pico-units.

• Isn't it possible to add an image and upload it in just one step instead of two?

Yes, we can fix this as well.

• It looks a bit weird that just the customer, initially, must signup and login, but I guess it's for the MVP; by the way, what's the purpose of the signup?

Here, we are taking the Tags that the user is interested in, to show the Homepage to his desired Tags. This ecosystem also has few centralized components for User Management, Pagination, Tasks based on Interests, etc.

• Milestone's button is Complete for a worker who bidded also if the customer accepted a bid of another worker (if you then click it, it says "project does not exist").

Could you please provide more information on this a screenshot may be.

Conclusion

To accept the milestone, i'd like to get answers for the Backend part, but the Frontend one is definetly not urgent, as those are just comments for improvement / bugs findings.

Thank you reviewing in detail. The suggestions were helpful.

@Loaki07 thanks a lot for the answers, and happy to see the feedback was useful. I've asked the team to accept the Milestone 1.

For the Milestone 2, I'm happy to accept also that one (as the comments you posted explain well the backend functioning) after the procedure for the first one is completed. In the meantime I can send you the screenshot for that frontend (minor) issue, and if you want you can also fix the other minor issues (it's an invite, not mandatory).

I'm also beginning the evaluation of Milestone 3.

@Loaki07 consider, by the way, that I plan to accept everything before the end of today (if the Milestone 3 is good). So probably would be more convenient to keep just one PR @Noc2?

• Milestone's button is Complete for a worker who bidded also if the customer accepted a bid of another worker (if you then click it, it says "project does not exist").

Could you please provide more information on this a screenshot may be.

@Loaki07 I've updated the Milestone 2 comment with two screenshots.

@0xCaso Thank you for the reviews.

A quick update, the issue where the UI breaks when you switch wallet in-between a process has been fixed. Now, any time it occurs it will take you back to the homepage where you will need to connect your wallet again to proceed. These changes are pushed both for Milestone 2 & 3.

• Milestone's button is Complete for a worker who bidded also if the customer accepted a bid of another worker (if you then click it, it says "project does not exist").

Could you please provide more information on this a screenshot may be.

@Loaki07 I've updated the Milestone 2 comment with two screenshots.

Thank you for pointing this out, this issue is also fixed in Milestone 3.

Milestone 3

For this one, I've got just two questions:

• The search_milestones functionality works well, but is there a way to make it free or users must pay fees to perform searches?

We've made the transaction fees as Pays::No. So, no money is charged for running the search.

• I couldn't upload the milestone's image (Click Add File -> I select the file -> Click Upload); could that be an issue with the NFT Storage service?
  

The files are not uploading at all?

We've made the transaction fees as Pays::No. So, no money is charged for running the search.

Oh sorry, didn't see that. Great then!

The files are not uploading at all?

I'm sorry, as I'm using a remote machine, I forgot to open the new ports 27019 and 8001. Now everything works perfectly! Could you please add in the README of dot_marketplace_docker which are the needed ports?

After that, I think everything else looks good.

We've made the transaction fees as Pays::No. So, no money is charged for running the search.

Oh sorry, didn't see that. Great then!

The files are not uploading at all?

I'm sorry, as I'm using a remote machine, I forgot to open the new ports 27019 and 8001. Now everything works perfectly! Could you please add in the README of dot_marketplace_docker which are the needed ports?

After that, I think everything else looks good.

Great! We've added the ports to the README.md

Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we’ve created a badge for projects that successfully deliver their first milestone. Note that it must only be used within the context of the delivered work, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant.

Furthermore, you're now welcome to announce the grant publicly. Please remember to observe the foundation’s guidelines in doing so. In case you haven't done so yet, you may also reach out to grantsPR@web3.foundation for feedback on your announcement and cross-promotion.

Thank you for your contribution and good luck with the remaining milestones, if any! As usual, please let us know if you run into any delays by leaving a comment on the application PR, or directly submitting an amendment.

@Loaki07 All the milestones have been accepted, congratulations and thanks for the cooperation!

Just one last thing: recently we changed our guidelines, and I would ask you if it's possible to change USDT on Ethereum as payment method to another option choosable from here (so if you want to stay with Ethereum you should change it to USDC or DAI).

If yes, it would be great if you could resend the three invoices changing the currency, and also adding the VAT Amount, which is 0.

Thank you! 😄

Could you please confirm if Bitcoin payment is possible, will reupload the invoices accordingly.

Could you please confirm if Bitcoin payment is possible, will reupload the invoices accordingly.

I confirm it, but for that you should amend the application in our Grants-Program repo (i.e., open a PR changing the Payment Address). When it will be accepted, you can resend the new invoices with the updated info.

@0xCaso The payment address to Bitcoin is updated in this pr. Also, reuploaded the invoices for all the 3 milestones.

Thanks a lot @Loaki07, but could you add the VAT Amount (0) inside the invoices?

We are consulting a tax lawyer, we'll upload the correct invoices based on the same.

@0xCaso
Thank you for your patience. I've re-uploaded the 3 invoices. Kindly, check and let us know.

Thanks again @Loaki07, I forwarded them internally! Please allow up to 14 days for the payment.

hi @Loaki07 we transferred the payment last week

It's been received, thank you!