Skip to content

Wika Network - Milestone 2#423

Merged
takahser merged 6 commits intow3f:masterfrom
randombishop:master
Apr 28, 2022
Merged

Wika Network - Milestone 2#423
takahser merged 6 commits intow3f:masterfrom
randombishop:master

Conversation

@randombishop
Copy link
Copy Markdown
Contributor

@randombishop randombishop commented Apr 18, 2022

Milestone Delivery Checklist

Link to the application pull request: w3f/Grants-Program#682

@randombishop randombishop mentioned this pull request Apr 18, 2022
Merged
9 tasks
@takahser takahser self-assigned this Apr 19, 2022
@takahser
Copy link
Copy Markdown
Contributor

takahser commented Apr 19, 2022

Thanks for the delivery @randombishop. We'll look into it as soon as possible.

takahser
takahser suggested changes Apr 19, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@takahser takahser left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect that the GitHub actions failed to execute because it wasn't able to locate the application document, since the url was placed on the next line.
image

Hence I suggest to apply the following structural changes.

randombishop and others added 2 commits April 19, 2022 08:17
@randombishop @takahser
Update deliveries/wika_network-milestone_2.md
7d874f5 
Co-authored-by: S E R A Y A <takahser@users.noreply.github.com>
@randombishop @takahser
Update deliveries/wika_network-milestone_2.md
189a088 
Co-authored-by: S E R A Y A <takahser@users.noreply.github.com>
@randombishop
Copy link
Copy Markdown
Contributor Author

randombishop commented Apr 19, 2022

Thanks for resolving the issue @takahser, the checks pass now. Looking forward to hearing back from you

takahser
takahser approved these changes Apr 28, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@takahser takahser left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @randombishop

Very clean delivery, I'm very happy with it so I already accepted. You can find my evaluation here: https://github.com/w3f/Grant-Milestone-Delivery/blob/master/evaluations/wika-network_2_takahser.md
The only issue I found were some warnings in the specs, I recommend you to take a look but it doesn't impact the acceptance of this delivery.
Also, I found a small mistake in your docs, so I fixed it here: randombishop/wika_api#5

Looking forward to M3, and again, good job on this one!

@takahser takahser merged commit 7f246df into w3f:master Apr 28, 2022
@randombishop
Copy link
Copy Markdown
Contributor Author

randombishop commented Apr 28, 2022

Big thanks @takahser!

Your feedback on previous one was perfect guidance so we could apply the learnings to this one, very happy about how smooth the process is. Have a great day!

@takahser
Copy link
Copy Markdown
Contributor

takahser commented May 2, 2022

@randombishop I'm happy to hear! I agree, this time the process was very smooth, I'm very happy with the quality of this delivery! Thanks again and have a great day as well!

failfmi pushed a commit to LimeChain/Grant-Milestone-Delivery that referenced this pull request Sep 26, 2022
@celrisen
NewOmega Application M3/M4 (w3f#423)
20853b6 
* NewOmega Application M3/M4

* Provide more technical implementation details

* Provide more technFuture plans and deliverables language
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@takahser takahser takahser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@takahser takahser

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@randombishop @takahser