Skip to content

Fractapp Milestone #2#117

Merged
semuelle merged 1 commit intow3f:masterfrom
elshan-eth:master
Apr 6, 2021
Merged

Fractapp Milestone #2#117
semuelle merged 1 commit intow3f:masterfrom
elshan-eth:master

Conversation

@elshan-eth
Copy link
Copy Markdown
Contributor

Milestone Delivery Checklist

@elshan-eth
Copy link
Copy Markdown
Contributor Author

elshan-eth commented Mar 21, 2021

Hi
Sorry for delay. Next Milestone we will try to finish faster.

We removed auth by Twitter because we think that its function will be not popular. Now we can connect by Email or Phone. And we added payment chats from Milestone 3.

Best regards

@semuelle
Copy link
Copy Markdown
Contributor

Hi Elshan, thanks for the delivery. We will look into it as soon as possible.

@semuelle semuelle self-assigned this Mar 23, 2021
@semuelle semuelle self-assigned this Mar 31, 2021
@semuelle
Copy link
Copy Markdown
Contributor

semuelle commented Apr 1, 2021

Hey @CryptoBadBoy, thanks for your patience with this evaluation.

I don't have a bin/mockgen under $GOPATH (as per your Makefile), can you tell what's missing?

@elshan-eth
Copy link
Copy Markdown
Contributor Author

Hello, @semuelle
You need to install https://github.com/golang/mock
I forgot to mention this in the readme

@semuelle
Copy link
Copy Markdown
Contributor

semuelle commented Apr 1, 2021

Thanks for the follow-up. I was able to run the tests with mock.

Could you add the mock requirement to the setup instructions and address the issues with documentation described in the evaluation notes under Deliverable 3 and the General Notes?

Otherwise 👍

@elshan-eth
Copy link
Copy Markdown
Contributor Author

elshan-eth commented Apr 2, 2021

@semuelle, thank you! I fixed it

@semuelle
Copy link
Copy Markdown
Contributor

semuelle commented Apr 6, 2021

Thanks for following up on the documentation. Your milestone is hereby accepted. 🎉

I will forward your invoice for processing.

@semuelle semuelle merged commit ac9c316 into w3f:master Apr 6, 2021
@semuelle
Copy link
Copy Markdown
Contributor

@CryptoBadBoy, it seems your invoice shows the wrong date, could you fix that and re-submit the form?

@elshan-eth
Copy link
Copy Markdown
Contributor Author

@semuelle, Hello
Need a date when the milestone was accepted? Or today?

The date on the invoice is when I created the pull request

@semuelle
Copy link
Copy Markdown
Contributor

It's the wrong year.

@elshan-eth
Copy link
Copy Markdown
Contributor Author

@semuelle

Sorry, I re-sent

Thank you!

@elshan-eth
Copy link
Copy Markdown
Contributor Author

@semuelle, Hello

Please tell me how soon will the grant be sent?

Thank you!

@semuelle
Copy link
Copy Markdown
Contributor

Hey Elshan. The invoices usually take a couple of days. You should hear from our finances team very soon.

@RouvenP
Copy link
Copy Markdown

RouvenP commented Apr 16, 2021

hi @CryptoBadBoy we transferred the BTC.

@elshan-eth
Copy link
Copy Markdown
Contributor Author

@semuelle @RouvenP, Thank you very much!

borispovod pushed a commit to pontem-network/Grant-Milestone-Delivery that referenced this pull request Apr 28, 2021
failfmi pushed a commit to LimeChain/Grant-Milestone-Delivery that referenced this pull request Sep 26, 2022
Manta: A Privacy Preserving Decentralized Exchange
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants