Define "prepare credential requests" algorithm by marcoscaceres · Pull Request #420 · w3c-fedid/digital-credentials

marcoscaceres · 2025-12-16T10:28:17Z

Added the "prepare credential requests" algorithm, detailing validation of each request, handling of unsupported protocols, error propagation, and abort signal integration.

Closes #432
Closes #249
Closes #220
Closes #207
Closes #159

The following tasks have been completed:

Modified Web platform tests

Implementation commitment:

WebKit
- https://bugs.webkit.org/show_bug.cgi?id=309625
- Digital Credential: CredentialRequestCoordinator can remain non-Idle if AbortSignal races with picker result WebKit/WebKit#56489
Chromium
Gecko (link to issue)

Documentation and checks

Preview | Diff

marcoscaceres · 2026-01-20T01:57:31Z

Blocked on tests.

…if AbortSignal races with picker result rdar://163295172 https://bugs.webkit.org/show_bug.cgi?id=305363 Reviewed by Pascoe. Fix race and crash in CredentialRequestCoordinator by settling promises only after picker teardown and safely handling abort reasons. Ensure credential requests always settle after the picker UI has fully torn down. This change: - Defers promise settlement until the picker dismiss callback fires - Better handles aborts during presentation and teardown - Avoids capturing unprotected JSValues across async boundaries - Keeps coordinator state transitions more consistent (with better checks) It also more closely follows the spec: w3c-fedid/digital-credentials#420 w3c-fedid/digital-credentials#419 * LayoutTests/imported/w3c/web-platform-tests/digital-credentials/get.tentative.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/digital-credentials/non-fully-active.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/digital-credentials/non-fully-active.https.html: * Source/WebCore/Modules/identity/CredentialRequestCoordinator.cpp: (WebCore::CredentialRequestCoordinator::PickerStateGuard::PickerStateGuard): (WebCore::CredentialRequestCoordinator::PickerStateGuard::~PickerStateGuard): (WebCore::CredentialRequestCoordinator::setState): (WebCore::CredentialRequestCoordinator::prepareCredentialRequest): (WebCore::CredentialRequestCoordinator::handleDigitalCredentialsPickerResult): (WebCore:: const): (WebCore::CredentialRequestCoordinator::dismissPickerAndSettle): (WebCore::CredentialRequestCoordinator::abortPicker): (WebCore::CredentialRequestCoordinator::contextDestroyed): (WebCore::CredentialRequestCoordinator::~CredentialRequestCoordinator): (): Deleted. (WebCore::CredentialRequestCoordinator::presentPicker): Deleted. (WebCore::CredentialRequestCoordinator::finalizeDigitalCredential): Deleted. * Source/WebCore/Modules/identity/CredentialRequestCoordinator.h: * Source/WebCore/Modules/identity/DigitalCredential.cpp: (WebCore::DigitalCredential::discoverFromExternalSource): * Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations: Canonical link: https://commits.webkit.org/305868@main

hlflanagan · 2026-01-22T14:44:09Z

Discussed in 21 January 2026 Series B call

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mohamedamir

Thanks Marcos!
Looks great!
I have added some comments!
Feel free to resolve async if you agree on them or discuss on our next weekly!

Co-authored-by: Mohamed Amir Yosef <mamir@chromium.org>

Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>

spam?

SHA: 63bd023 Reason: push, by marcoscaceres Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

marcoscaceres mentioned this pull request Jan 7, 2026

Fixup algorithms in credential creation and request steps. #418

Merged

9 tasks

marcoscaceres force-pushed the prepare branch from 0110b09 to 0aa302c Compare January 8, 2026 07:33

marcoscaceres mentioned this pull request Jan 9, 2026

Update get procedure for when UA does not support a protocol #432

Closed

MasterKale mentioned this pull request Jan 9, 2026

Add guidance on how to handle multiple presentation request entries #249

Closed

9 tasks

marcoscaceres force-pushed the prepare branch from d02002d to bb35ade Compare January 13, 2026 01:02

marcoscaceres marked this pull request as ready for review January 13, 2026 12:50

marcoscaceres requested a review from a team as a code owner January 13, 2026 12:50

marcoscaceres mentioned this pull request Jan 13, 2026

Digital Credential: CredentialRequestCoordinator can remain non-Idle if AbortSignal races with picker result WebKit/WebKit#56489

Merged

marcoscaceres force-pushed the prepare branch from bb35ade to 0222f65 Compare January 13, 2026 23:22

marcoscaceres added agenda+ Add to the weekly agenda BLOCKED labels Jan 20, 2026

jschanck reviewed Jan 21, 2026

View reviewed changes

Comment thread index.html Outdated

Comment thread index.html Outdated

Comment thread index.html Outdated

Comment thread index.html Outdated

Comment thread index.html Outdated

marcoscaceres mentioned this pull request Jan 21, 2026

Change from Registry to Protocols #401

Merged

9 tasks

mohamedamir reviewed Jan 21, 2026

View reviewed changes

Comment thread index.html Outdated

mohamedamir reviewed Jan 21, 2026

View reviewed changes

Comment thread index.html Outdated

colelao mentioned this pull request Jan 22, 2026

WIP Fix Screen Wake Lock in Site Isolation WebKit/WebKit#57011

Closed

marcoscaceres force-pushed the prepare branch from d11d30f to 14054cb Compare January 28, 2026 08:26

marcoscaceres requested review from jschanck and mohamedamir January 28, 2026 08:40

marcoscaceres force-pushed the prepare branch from 35336be to 0b7552c Compare February 3, 2026 04:07

marcoscaceres requested review from Copilot and removed request for jschanck February 3, 2026 04:35

Copilot started reviewing on behalf of marcoscaceres March 5, 2026 10:59 View session

Copilot AI reviewed Mar 5, 2026

View reviewed changes

Comment thread index.html Outdated

Comment thread index.html Outdated

Comment thread index.html Outdated

marcoscaceres commented Mar 5, 2026

View reviewed changes

Comment thread index.html

Apply suggestions from code review

6a2240b

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

marcoscaceres requested review from Copilot and mohamedamir March 10, 2026 05:28

Copilot started reviewing on behalf of marcoscaceres March 10, 2026 05:29 View session

Copilot AI reviewed Mar 10, 2026

View reviewed changes

Comment thread index.html

Comment thread index.html

mohamedamir reviewed Mar 10, 2026

View reviewed changes

Comment thread index.html

mohamedamir reviewed Mar 10, 2026

View reviewed changes

Comment thread index.html

mohamedamir reviewed Mar 10, 2026

View reviewed changes

Comment thread index.html

mohamedamir reviewed Mar 10, 2026

View reviewed changes

Comment thread index.html Outdated

mohamedamir reviewed Mar 10, 2026

View reviewed changes

Comment thread index.html Outdated

mohamedamir approved these changes Mar 10, 2026

View reviewed changes

Apply suggestions from code review

dfc6992

Co-authored-by: Mohamed Amir Yosef <mamir@chromium.org>

marcoscaceres mentioned this pull request Mar 10, 2026

Order of serialization vs protocol filtering #475

Closed

anowardear062-svg previously approved these changes Mar 10, 2026

View reviewed changes

TallTed reviewed Mar 10, 2026

View reviewed changes

Comment thread index.html Outdated

marcoscaceres and others added 4 commits March 11, 2026 10:06

Update index.html

733932c

Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>

Add assert and note

51c0de0

fixup DigitalCredentialGetRequests

c467f3f

Address review feedback

fd76d69

marcoscaceres commented Mar 11, 2026

View reviewed changes

Comment thread index.html Outdated

Apply suggestion from @marcoscaceres

1994d34

w3c-fedid deleted a comment from anowardear062-svg Mar 11, 2026

marcoscaceres mentioned this pull request Mar 11, 2026

Digital credentials: prepare algorithm tests web-platform-tests/wpt#58420

Open

marcoscaceres merged commit 63bd023 into main Mar 12, 2026
3 checks passed

marcoscaceres deleted the prepare branch March 12, 2026 07:35

github-actions Bot added a commit that referenced this pull request Mar 12, 2026

Define "prepare credential requests" algorithm (#420)

6c9fcfa

SHA: 63bd023 Reason: push, by marcoscaceres Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Conversation

marcoscaceres commented Dec 16, 2025 • edited by pr-preview Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marcoscaceres commented Jan 20, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hlflanagan commented Jan 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mohamedamir left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

marcoscaceres commented Dec 16, 2025 •

edited by pr-preview Bot

Loading