Fixup algorithms in credential creation and request steps.#418
Merged
Conversation
* Fix variable naming inconsistencies. * User activation is now checked after data checks, to match Chrome and Webkit.
ea29bbd to
bc12b27
Compare
Collaborator
Author
|
Ok, this one is mostly editorial now... in both WebKit and Chromium, the user activation check is done after validation of the requests. |
mohamedamir
approved these changes
Jan 15, 2026
mohamedamir
left a comment
Collaborator
There was a problem hiding this comment.
I confirm that Chromium implementation matches this!
Thanks Marcos!
Collaborator
Author
|
Reviewed with @mohamedamir to make sure that Chrome does the same thing (it does). Next steps is to update the tests. (BLOCKED) |
Collaborator
Author
|
@timcappalli, can you check and, if all good, ✅ please 🙏 |
marcoscaceres
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 19, 2026
Validation errors (TypeError) no longer consume user activation since validation now happens before user activation checking. Spec change: w3c-fedid/digital-credentials#418
Collaborator
Author
|
Added tests web-platform-tests/wpt#57231 ... unblocked. |
timcappalli
approved these changes
Jan 20, 2026
github-actions Bot
added a commit
that referenced
this pull request
Jan 20, 2026
SHA: 7ad0be8 Reason: push, by marcoscaceres Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #202
The following tasks have been completed:
Implementation commitment:
Documentation and checks
Preview | Diff