Value of "webSocketUrl" capability cannot be "false" after capability matching#725
Merged
Value of "webSocketUrl" capability cannot be "false" after capability matching#725
Conversation
jgraham
requested changes
Jun 5, 2024
Contributor
Author
|
@jgraham please re-review. Thanks. |
jgraham
approved these changes
Jun 5, 2024
sadym-chromium
pushed a commit
that referenced
this pull request
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per CDDL it's not allowed to return a boolean value for
webSocketUrl. As such we need to check the existence and value of this capability first so that it can be removed if it's nottrue.@jgraham can you please review? Thanks.
Preview | Diff