Add hook to emulate navigator.language/s#1017
Conversation
juliandescottes
left a comment
There was a problem hiding this comment.
Just a question regarding the number of algorithms defined here, but otherwise this looks good given the changes in the HTML draft PR.
…override for environment".
Co-authored-by: Maksim Sadym <69349599+sadym-chromium@users.noreply.github.com>
4c9de0d to
d5222bb
Compare
Co-authored-by: Maksim Sadym <69349599+sadym-chromium@users.noreply.github.com>
|
Alright, thanks for the reviews! I'm going to merge it now. @sadym-chromium, could you create an issue on your side to implement this so I could link it in the PR for html spec? |
SHA: a51a94f Reason: push, by lutien Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
GoogleChromeLabs/chromium-bidi#3863 Please note that you also need WPT tests before landing HTML PR. |
Thanks for creating the issue!
The PR to update the tests is actually here: web-platform-tests/wpt#55453. |
|
@lutien hope it's not too late, but what I just thought about is maybe it makes sense to split the locale and language? i.e. we can either extend the |
I think according to our discussions here, the consensus was that all the values have to synchronized, so there is no point to have multiple arguments or commands. Do you have any specific use/reason in mind where it would make sense to split? |
Add the required hook for the WebDriver BiDi spec w3c/webdriver-bidi#1017
Add the required hook for the WebDriver BiDi spec w3c/webdriver-bidi#1017
Add hook which is going to be used in html spec to set emulation for
navigator.language/s.HTML spec draft PR: whatwg/html#11793.
Preview | Diff