Skip to content

Conversation

@sadym-chromium
Copy link
Contributor

@sadym-chromium sadym-chromium commented Sep 17, 2025

To ease integration with external specifications, I specified the argument types for all the "WebDriver BiDi ..." hooks.

  • Add types for all external ("WebDriver BiDi ...") hooks.
  • Proper reference to the the |navigation status| struct fields.

Preview | Diff

@sadym-chromium sadym-chromium changed the title [editorial]: typed "WebDriver BiDi" hooks [editorial]: typed external "WebDriver BiDi ..." hooks Sep 17, 2025
@sadym-chromium
Copy link
Contributor Author

@OrKoN @jgraham WDYT?

Copy link
Contributor

@whimboo whimboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While reviewing this PR some questions popped-up for me. Please check them inline. Thanks.

Co-authored-by: Henrik Skupin <mail@hskupin.info>
@sadym-chromium sadym-chromium requested a review from whimboo October 1, 2025 11:48
Copy link
Contributor

@whimboo whimboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be fine now. Thanks!

@sadym-chromium sadym-chromium merged commit d8c8a0e into main Oct 1, 2025
5 checks passed
@sadym-chromium sadym-chromium deleted the sadym/typed-external-hooks branch October 1, 2025 12:31
github-actions bot added a commit that referenced this pull request Oct 1, 2025
SHA: d8c8a0e
Reason: push, by sadym-chromium

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants