Skip to content

Fix issues with User Prompt Handler after PR #1791#1812

Merged
whimboo merged 5 commits intow3c:masterfrom
whimboo:prompt_handler
May 21, 2024
Merged

Fix issues with User Prompt Handler after PR #1791#1812
whimboo merged 5 commits intow3c:masterfrom
whimboo:prompt_handler

Conversation

@whimboo
Copy link
Copy Markdown
Contributor

@whimboo whimboo commented May 16, 2024 •
edited by pr-preview Bot
Loading

With PR #1791 we got extended support for the unhandledPromptBehavior landed which added a new Object type to define handlers for all the prompt handlers more granularly.

While implementing the capability handling for that new type in Firefox I noticed a couple of issue. This PR fixes these and also updates some cases to make it better understandable what specific variables actually are.

FYI @sadym-chromium @nechaev-chromium @gsnedders for when you get started to implement these changes in the drivers.

Updated tests will be part of my work on https://bugzilla.mozilla.org/show_bug.cgi?id=1895738.

Preview | Diff

@whimboo whimboo requested a review from jgraham May 16, 2024 20:55
jgraham
jgraham requested changes May 17, 2024
View reviewed changes
Comment thread index.html Outdated
Comment thread index.html Outdated
Comment thread index.html
@whimboo whimboo force-pushed the prompt_handler branch 2 times, most recently from 1a27a9d to e4007c6 Compare May 21, 2024 11:26
@whimboo whimboo requested a review from jgraham May 21, 2024 11:28
@whimboo whimboo mentioned this pull request May 21, 2024
Open
@whimboo whimboo requested a review from OrKoN May 21, 2024 12:43
@whimboo
Copy link
Copy Markdown
Contributor Author

whimboo commented May 21, 2024

@OrKoN mind a quick review as well? Thanks a lot.

OrKoN
OrKoN reviewed May 21, 2024
View reviewed changes
Comment thread index.html
@whimboo whimboo requested a review from OrKoN May 21, 2024 21:00
OrKoN
OrKoN approved these changes May 21, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@OrKoN OrKoN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whimboo whimboo merged commit 48a221b into w3c:master May 21, 2024
@whimboo whimboo deleted the prompt_handler branch May 21, 2024 21:35
github-actions Bot added a commit that referenced this pull request May 21, 2024
@whimboo @github-actions
Fix issues with User Prompt Handler after PR #1791 (#1812)
2529b58 
SHA: 48a221b
Reason: push, by whimboo

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot added a commit to xjc90s/webdriver that referenced this pull request May 22, 2024
@whimboo @github-actions
Fix issues with User Prompt Handler after PR w3c#1791 (w3c#1812)
a008633 
SHA: 48a221b
Reason: push, by pull[bot]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot added a commit to soloinovator/webdriver that referenced this pull request May 24, 2024
@whimboo @github-actions
Fix issues with User Prompt Handler after PR w3c#1791 (w3c#1812)
b7a539f 
SHA: 48a221b
Reason: push, by pull[bot]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgraham jgraham jgraham approved these changes

@OrKoN OrKoN OrKoN approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@whimboo @jgraham @OrKoN