Conversation
|
I'm not familiar with ReSpec. @marcoscaceres would be great for this if he has time. |
|
👍 Thanks! I was mostly wondering whether it seemed reasonable to you to assign the |
|
Yeah that's fine. Looking at the patch it is somewhat weird that when accessing the slot it's not made clear what instance it's being accessed on. Usually you'd see something like "this's [[slot]]" or "instance's [[slot]]". |
|
Yeah, that's true. As originally envisioned, (Or perhaps this concept should be reworked entirely. I believe the original intention was to make the spec extensible by other specs, which could register additional algorithms on this object, but it's not actually necessary to have an object that can be extended at runtime, say. So perhaps there's a better way to express this spec-level / implementation-level "registry". But ok, if so that should probably be a separate PR.) |
|
My general approach to registries is to "just say no" and require a PR with the appropriate sign-offs when an extension is needed. It does seem good to work out what the scope of this is first, before tying it to a specific object. |
Also, make it a free-standing object again.
|
OK, yeah. I tend to agree, I can get rid of it in a separate PR. For now, I've made it a free-standing object again and renamed it from |
|
Happy to help, but give me day or two... better next week - but this is a good start. |
|
This all seems good. As a followup, we might want to add a .pr_preview.json file too. |
|
👍 Thanks, will do! |
This updates the usage of ReSpec from respec-w3c-common to respec-w3c, as per these guidelines, and then fixes all the things it complained about, most notably properly marking the internal slots of
CryptoKeyobjects as belonging toCryptoKeyin WebIDL.The most non-mechanical change here is that the
[[supportedAlgorithms]]internal object, which is sort of "free-floating" and not connected to any object (which respec-w3c complains about, which is fair enough), is now an internal slot of theSubtleCryptointerface. (This is purely an internal WebIDL change, it's not mentioned in the text.) Hopefully this makes sense to people.And finally, it marks the spec as belonging to the webappsec group.