fixup algs contd 2#495
Merged
Merged
Conversation
This was referenced Jun 16, 2017
Merged
AngeloKai
approved these changes
Jun 22, 2017
AngeloKai
left a comment
Contributor
There was a problem hiding this comment.
This would be a step closer to fix the algorithm. We should merge this to get us on track soon.
AngeloKai
suggested changes
Jun 22, 2017
AngeloKai
left a comment
Contributor
There was a problem hiding this comment.
I looked through too quickly. PR 495 and 498 are actually two approaches instead of improving on top of the other. I will comment on 498.
equalsJeffH
commented
Jun 27, 2017
| Note: In this case, the [=[RP]=] did not supply a list of acceptable credential descriptors. Thus the | ||
| authenticator is being asked to exercise any credential it may possess that is bound to the [=[RP]=]. | ||
| authenticator is being asked to exercise any credential it may possess that is bound to | ||
| the [=[RP]=] identified by |rpId|. |
Contributor
Author
There was a problem hiding this comment.
s/identified/as identified/
Contributor
Author
AngeloKai
approved these changes
Jun 27, 2017
AngeloKai
left a comment
Contributor
There was a problem hiding this comment.
Thx Jeff for the clarification. If this is considered a standalone PR, I'd consider it approved.
Contributor
Author
|
can we go ahead and merge this given @rlin1's and @AngeloKai's reviews? thx. |
jcjones
approved these changes
Jul 5, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Presently, this (hopefully) fixes #480.
This also fixes #475 ("Level 1" editorial addition).
update 28-Jun-2017: this also (re-) fixes #268
Preview | Diff