Integrity-Policy - Fix up the discrepancy with Fetch integrity metadata#135
Merged
Conversation
mozfreddyb
approved these changes
May 27, 2025
Collaborator
|
thanks! |
This was referenced Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current "should request be blocked by integrity policy" algorithm isn't super clear on what happens when the integrity metadata is invalid, and the fact that "integrity metadata" means different things in Fetch and in SRI doesn't help. This PR clarifies that we should deal with parsed metadata, where invalid metadata results in a empty metadata set.
This matches the tests, and seems more consistent than the alternative (avoid blocking invalid integrity metadata, which would result in a bypass of Integrity-Policy in the case of a CORS-enabled fetch).
Preview | Diff