Add immediate mediation#272
Conversation
|
@marcoscaceres, could you take a look as well? Thanks! |
Added uiMode field to enable 'immediate' without it being a mediation enum value
Fix reference
nsatragno
left a comment
There was a problem hiding this comment.
Thank you for doing this work! Some comments below:
Addressed nsatragno's comments
nsatragno
left a comment
There was a problem hiding this comment.
Approved with a comment, happy to merge after that gets solved.
Address some review comments
SHA: 44bbda9 Reason: push, by nsatragno Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Oh! We should consider getting multi implementer reviews and commitments (as well as filing implementation bugs) before merging PRs going forward. Otherwise we risk having stuff not get implemented or having to remove things in the spec as happened with #279 |
|
Fair, although I'm not sure how to resolve the fact that because WebAuthn depends on this spec, patches generally have to land here first. |
|
That’s totally fine I think. As long as someone implements stuff. At the same time, other specs depend on this spec, so we need to carefully consider what the impact might be on, say, the DC API. |
This PR adds a new enumeration value to
CredentialMediationRequirement, corresponding to the immediate mediation proposal described in a WebAuthn explainer.The WebAuthn issue: w3c/webauthn#2228
A WebAuthn PR will follow that references this mediation value.
Preview | Diff