Clarify name for recommended mark for feature usag based on feedback#108
Merged
anniesullie merged 1 commit intogh-pagesfrom Nov 14, 2023
Merged
Clarify name for recommended mark for feature usag based on feedback#108anniesullie merged 1 commit intogh-pagesfrom
anniesullie merged 1 commit intogh-pagesfrom
Conversation
This was referenced Nov 14, 2023
ksylor
approved these changes
Nov 14, 2023
ksylor
left a comment
There was a problem hiding this comment.
LGTM! Thanks for changing the name to something easier to understand!
3 tasks
alxhub
pushed a commit
to angular/angular
that referenced
this pull request
Dec 13, 2023
This commit updates the name of the 'performance.mark' counter used to track feature usage. It now matches the name agreed upon by W3C for this use case: w3c/user-timing#108 PR Close #53542
alxhub
pushed a commit
to angular/angular
that referenced
this pull request
Dec 13, 2023
This commit updates the name of the 'performance.mark' counter used to track feature usage. It now matches the name agreed upon by W3C for this use case: w3c/user-timing#108 PR Close #53542
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
This commit updates the name of the 'performance.mark' counter used to track feature usage. It now matches the name agreed upon by W3C for this use case: w3c/user-timing#108 PR Close angular#53542
rlmestre
pushed a commit
to rlmestre/angular
that referenced
this pull request
Jan 26, 2024
This commit updates the name of the 'performance.mark' counter used to track feature usage. It now matches the name agreed upon by W3C for this use case: w3c/user-timing#108 PR Close angular#53542
amilamen
pushed a commit
to amilamen/angular
that referenced
this pull request
Jan 26, 2024
This commit updates the name of the 'performance.mark' counter used to track feature usage. It now matches the name agreed upon by W3C for this use case: w3c/user-timing#108 PR Close angular#53542
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
People found
mark_use_counterconfusing and recommended a name that's meaningful outside of Chrome's "use counter" terminology. A follow up on #105Preview | Diff