Add content-type to resource-timing by abinpaul1 · Pull Request #341 · w3c/resource-timing

abinpaul1 · 2022-08-22T14:59:00Z

Introducing Content type. (#203)
Fetch changes : whatwg/fetch#1481

Explainer : https://github.com/abinpaul1/resource-timing/blob/explainer-content-type/Explainers/Content-Type.md

💥 Error: Server Error 💥

PR Preview failed to build. (Last tried on May 8, 2023, 11:28 AM UTC).

More

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

abinpaul1 · 2022-09-04T15:22:20Z

I was trying to spec this out keeping in mind, the points mentioning not to reflect the header directly and only a set of relevant MIME types.

It is currently(in this PR) specified to allow any MIME type that matches the groups presented in https://mimesniff.spec.whatwg.org/#mime-type-groups.
Taking the case of say a ZIP-based MIME type, its described as any MIME type whose subtype ends in "+zip". So a content type such as application/u.26363-43323-42424+zip would be valid and reflected, which is not desired.
To get around this, AFAIU we would need to define an exhaustive list of allowed MIME types to match against. I don't think we can go with the list that was mentioned in the WG call (https://www.iana.org/assignments/media-types/media-types.xhtml) because a good majority of those do not seem to be relevant for the use cases.
If we were to keep an exhaustive list, which would be the more appropriate place to keep this? (MIME sniffing/Resource Timing). Such a list would have to updated as well when a new relevant content-type gains traction as well.

yoavweiss · 2022-09-05T06:06:41Z

@abinpaul1 - can we just reflect the MIME type's essensce?

abinpaul1 · 2022-09-05T07:03:35Z

Yeah, but when we reflect the essence wouldn't this be a valid essence : application/u.26363-43323-42424+zip ?
Here application would be type and u.26363-43323-42424+zip is the subtype

yoavweiss · 2022-09-05T07:16:25Z

Yeah, you're right.. Maybe it'd be possible to convince the MIMESNIFF editors to modify that definition, or otherwise monkeypatch it, if ZIP is the only mimetype that can expose such UIDs

/cc @domenic @annevk

abinpaul1 · 2022-09-05T07:25:16Z

I don't think ZIP is the only one that can have such UIDs.
JSON, XML MIME types also only requires subtype to end with +json, +xml. Morover, Image and audio/video MIME types does not have any restrictions on subtype (only requires the type to be image/audio/video)

domenic · 2022-09-05T08:12:08Z

Why is the full MIME type string not reflected? I couldn't find any reasoning in the explainer at https://github.com/abinpaul1/resource-timing/blob/explainer-content-type/Explainers/Content-Type.md#content-type-values.

abinpaul1 · 2022-09-05T10:02:10Z

During the WG call when this was discussed, a concern was raised regarding reflecting the exact same value returned by server.
From what I could understand the concern was mainly to protect against having any unique identifier as part of content-type in server response being relflected through resource timing API. @achristensen07, it would be great if you could please confirm or expand on the concern.

yoavweiss · 2022-09-05T10:06:36Z

I believe the concerns are related to w3c/server-timing#89 and are planned to be discussed at TPAC.

yoavweiss

LGTM once the Fetch PR lands

This CL introduces a contentType field to Performance Resource Timing object. This field is behind a Runtime Enabled Flag. Resource Timing PR : w3c/resource-timing#341 Fetch PR : whatwg/fetch#1481 Bug:1366706 Change-Id: If4c92ef96d74e3ddbb71420ac61dbea4bfa1163b

This CL introduces a contentType field to Performance Resource Timing object. This field is behind a Runtime Enabled Flag. Resource Timing PR : w3c/resource-timing#341 Fetch PR : whatwg/fetch#1481 Bug: 1366706 Change-Id: If4c92ef96d74e3ddbb71420ac61dbea4bfa1163b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3916841 Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Abin Paul <abin.paul1@gmail.com> Cr-Commit-Position: refs/heads/main@{#1063289}

yoavweiss

LGTM

…iming, a=testonly Automatic update from web-platform-tests Add content-type to PerformanceResourceTiming This CL introduces a contentType field to Performance Resource Timing object. This field is behind a Runtime Enabled Flag. Resource Timing PR : w3c/resource-timing#341 Fetch PR : whatwg/fetch#1481 Bug: 1366706 Change-Id: If4c92ef96d74e3ddbb71420ac61dbea4bfa1163b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3916841 Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Abin Paul <abin.paul1@gmail.com> Cr-Commit-Position: refs/heads/main@{#1063289} -- wpt-commits: 4c8e480994182b5cdc60f5c01ebf208df70ec73e wpt-pr: 36059

RByers · 2023-04-25T14:54:15Z

Is there something blocking this PR from landing?
Context: blink intent to ship

yoavweiss · 2023-04-25T15:04:23Z

This is waiting on the Fetch PR to land.

This defines the content type field as a minimized version of the response's parsed Content-Type header, to give web developers enough information to distinguish responses, but not enough to make it an additional communication channel. This feature will be used by Resource Timing as per w3c/resource-timing#341. Tests: ...

This defines the content type field as a minimized version of the response's parsed Content-Type header, to give web developers enough information to distinguish responses, but not enough to make it an additional communication channel. This feature will be used by Resource Timing as per w3c/resource-timing#341. Co-authored-by: Anne van Kesteren <annevk@annevk.nl>

yoavweiss

LGTM

…iming, a=testonly Automatic update from web-platform-tests Add content-type to PerformanceResourceTiming This CL introduces a contentType field to Performance Resource Timing object. This field is behind a Runtime Enabled Flag. Resource Timing PR : w3c/resource-timing#341 Fetch PR : whatwg/fetch#1481 Bug: 1366706 Change-Id: If4c92ef96d74e3ddbb71420ac61dbea4bfa1163b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3916841 Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Abin Paul <abin.paul1@gmail.com> Cr-Commit-Position: refs/heads/main@{#1063289} -- wpt-commits: 4c8e480994182b5cdc60f5c01ebf208df70ec73e wpt-pr: 36059

Add content-type to resource-timing

a049f7b

abinpaul1 mentioned this pull request Aug 22, 2022

Pass in content type to resource-timing whatwg/fetch#1481

Merged

3 tasks

abinpaul1 marked this pull request as draft August 22, 2022 15:02

abinpaul1 added 2 commits September 11, 2022 17:58

Move content-type into response body info

58f89ae

Merge branch 'gh-pages' into content-type

5fc263d

yoavweiss reviewed Sep 26, 2022

View reviewed changes

Comment thread index.html Outdated

Comment thread index.html

Mention possibility of truncating by user agents

cd18738

abinpaul1 marked this pull request as ready for review September 26, 2022 15:43

yoavweiss reviewed Sep 26, 2022

View reviewed changes

Comment thread index.html Outdated

yoavweiss approved these changes Sep 26, 2022

View reviewed changes

Add link to user agent

c629428

abinpaul1 changed the title ~~[draft] Add content-type to resource-timing~~ Add content-type to resource-timing Sep 26, 2022

chromium-wpt-export-bot mentioned this pull request Oct 24, 2022

Add content-type to PerformanceResourceTiming web-platform-tests/wpt#36059

Merged

Merge branch 'gh-pages' into content-type

bcf3bcd

yoavweiss approved these changes Nov 10, 2022

View reviewed changes

Remove stripping

25bab4e

annevk reviewed Nov 14, 2022

View reviewed changes

Comment thread index.html

Serialize instead of returning essence

584cfde

This was referenced Nov 14, 2022

Content-type in Resource Timing mozilla/standards-positions#705

Closed

Content-type in Resource Timing w3ctag/design-reviews#785

Closed

Content-type in Resource Timing WebKit/standards-positions#88

Closed

Return minimzed content type received from fetch

4fe2777

yoavweiss approved these changes May 9, 2023

View reviewed changes

yoavweiss merged commit 41d9808 into w3c:gh-pages May 11, 2023

nicjansma mentioned this pull request Mar 1, 2024

Expose Content-Encoding to ResourceTiming #381

Closed

Conversation

abinpaul1 commented Aug 22, 2022 • edited by pr-preview Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💥 Error: Server Error 💥

Uh oh!

abinpaul1 commented Sep 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yoavweiss commented Sep 5, 2022

Uh oh!

abinpaul1 commented Sep 5, 2022

Uh oh!

yoavweiss commented Sep 5, 2022

Uh oh!

abinpaul1 commented Sep 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

domenic commented Sep 5, 2022

Uh oh!

abinpaul1 commented Sep 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yoavweiss commented Sep 5, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yoavweiss left a comment

Choose a reason for hiding this comment

Uh oh!

yoavweiss left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

RByers commented Apr 25, 2023

Uh oh!

yoavweiss commented Apr 25, 2023

Uh oh!

yoavweiss left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

abinpaul1 commented Aug 22, 2022 •

edited by pr-preview Bot

Loading

abinpaul1 commented Sep 4, 2022 •

edited

Loading

abinpaul1 commented Sep 5, 2022 •

edited

Loading

abinpaul1 commented Sep 5, 2022 •

edited

Loading