Skip to content

Editorial: use new user activation model#885

Merged
marcoscaceres merged 5 commits intogh-pagesfrom
transient
Dec 11, 2019
Merged

Editorial: use new user activation model#885
marcoscaceres merged 5 commits intogh-pagesfrom
transient

Conversation

@marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Dec 6, 2019

closes #883

The following tasks have been completed:

  • Confirmed there are no ReSpec errors/warnings.

Preview | Diff

@marcoscaceres marcoscaceres requested a review from domenic December 6, 2019 05:26
@marcoscaceres
Copy link
Member Author

@mustaqahmed, @domenic, ok.... first shot at this. Let me know how it looks. See also my other comments in the relevant HTML bug.

@ianbjacobs
Copy link
Collaborator

Thanks @marcoscaceres

Copy link
Collaborator

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly seems good.

Should this consume user activation, or just observe it? That's probably a question for implementers and/or the working group?

@marcoscaceres
Copy link
Member Author

marcoscaceres commented Dec 9, 2019

Should this consume user activation, or just observe it? That's probably a question for implementers and/or the working group?

I think because this predates the new user activation model in HTML, it's currently "transient". It's definitely transient in Gecko right now - but I think because of the modal nature the payment sheet, we should consume user activation.

@aestes, @danyao, @rsolomakhin... the problem we are solving is:

window.onclick = () => {
   // set up payment stuff...
   const pay = request.show();
   // Does this succeed or reject? i.e., did .show() "consume" the user activation.
   document.body.requestFullscreen();
}

@marcoscaceres
Copy link
Member Author

I’ll add tests once we deal with consume.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rephrase "triggered by user activation" to match the new user activation model

4 participants