Add toRdf tests for merging rootless base paths#103
Merged
gkellogg merged 2 commits intow3c:masterfrom Jun 10, 2019
Merged
Conversation
Member
|
Marked as non substantive for IPR from ash-nazg. |
1 similar comment
Member
Author
|
Marked as non substantive for IPR from ash-nazg. |
Contributor
|
There is a similar jsonld.js issue. There are likely more tricky test cases and test variations that could be written to cover these issues. |
Member
Author
|
Added a test case for a base URI with a trailing slash, which (according to my understanding of the second bullet point in https://tools.ietf.org/html/rfc3986#section-5.2.3) results in preserving the full base URI (the scenario in digitalbazaar/jsonld.js#305). |
toRdf tests for merging rootless base URL paths
gkellogg
approved these changes
Jun 10, 2019
Member
gkellogg
left a comment
There was a problem hiding this comment.
My implementation currently fails as it doesn't doesn't handle tag:example as having an empty base path, but this seems to be the correct interpretation.
fsteeg
added a commit
to fsteeg/jsonld-java
that referenced
this pull request
Jun 11, 2019
Add new spec tests, remove custom tests See: jsonld-java#232 w3c/json-ld-api#103
fsteeg
added a commit
to fsteeg/jsonld-java
that referenced
this pull request
Jun 11, 2019
Add new spec tests, remove custom tests See: jsonld-java#232 w3c/json-ld-api#103
rubensworks
added a commit
to rubensworks/relative-to-absolute-iri.js
that referenced
this pull request
Jun 12, 2019
As discovered in w3c/json-ld-api#103
rubensworks
added a commit
to rubensworks/jsonld-streaming-parser.js
that referenced
this pull request
Jun 12, 2019
As introduced in w3c/json-ld-api#103
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came up in an issue with jsonld-java:
jsonld-java/jsonld-java#232
See second bullet point in:
https://tools.ietf.org/html/rfc3986#section-5.2.3