inserted text on positioning of characters of ruby annotation on block direction#320
Merged
himorin merged 2 commits intow3c:gh-pagesfrom Jun 21, 2022
Merged
inserted text on positioning of characters of ruby annotation on block direction#320himorin merged 2 commits intow3c:gh-pagesfrom
himorin merged 2 commits intow3c:gh-pagesfrom
Conversation
xfq
reviewed
Nov 27, 2021
index.html
Outdated
Comment on lines
+3744
to
+3746
| <p its-locale-filter-list="ja" lang="ja">行送り方向のルビの配置位置は，親文字の文字の外枠とルビ文字の文字の外枠を接して配置するのが原則である． | ||
| しかし，視覚障碍者にとって，親文字とルビの行送り方向の間隔がある程度は空いているのが望ましい場合もあり， | ||
| この間隔は変更できることが望ましい．</p> |
Member
There was a problem hiding this comment.
Since w3c/csswg-drafts#5086 hasn't been resolved yet, maybe we shouldn't insert line feeds in the Japanese version?
Contributor
Author
There was a problem hiding this comment.
ah, could be...
(actually, this was a trick in old age of Japanese web pages, to break at punctuation marks..)
kidayasuo
approved these changes
Jun 21, 2022
Contributor
kidayasuo
left a comment
There was a problem hiding this comment.
The change looks good. approving.
deniak
pushed a commit
that referenced
this pull request
Mar 24, 2025
inserted text on positioning of characters of ruby annotation on block direction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc @KobayashiToshi
Added text per comment provided.
closes #319
Preview | Diff