Skip to content

Update URL when swithing the language in UI#262

Merged
kojiishi merged 2 commits intow3c:gh-pagesfrom
kojiishi:switch-lang-to-url-search-params
Feb 14, 2024
Merged

Update URL when swithing the language in UI#262
kojiishi merged 2 commits intow3c:gh-pagesfrom
kojiishi:switch-lang-to-url-search-params

Conversation

@kojiishi
Copy link
Contributor

@kojiishi kojiishi commented Apr 22, 2021

This patch changes to update the URL search parameters when
switching the language in UI. This change can ensure the URL
can navigate to what the user is seeing.

Fixes #236.

@himorin himorin requested a review from r12a April 29, 2021 14:11
@himorin himorin mentioned this pull request Oct 13, 2021
Closed
@kidayasuo
Copy link
Contributor

kidayasuo commented Dec 2, 2021

Hello @r12a could you review this one? thanks!

@kidayasuo
Copy link
Contributor

kidayasuo commented Feb 14, 2024

@r12a could you add your review? I would like to add this fix in the final (I hope) update of JLReq.
thank you!

@r12a
Copy link
Contributor

r12a commented Feb 14, 2024

I haven't checked the code in detail, but i read #236 and this seems like a useful feature, so long as the user is still presented with the buttons allowing them to choose an alternative language. If that's not the case, i won't approve this change. @kojiishi can you confirm?

@kojiishi
Copy link
Contributor Author

kojiishi commented Feb 14, 2024

@r12a

so long as the user is still presented with the buttons allowing them to choose an alternative language. If that's not the case, i won't approve this change. @kojiishi can you confirm?

Yes, the latest editor's draft still has the buttons on the top-right corner.
image

@r12a
Copy link
Contributor

r12a commented Feb 14, 2024

But the latest ED presumably doesn't include these changes(?) since they haven't been merged yet.

To speed things up i'll mark this as accepted on the assumption that the buttons will still be there after merging. I took another look at the code, and it doesn't seem to affect the buttons.

@kojiishi
Update URL when swithing the language in UI
dba9cd9 
This patch changes to update the URL search parameters when
switching the language in UI. This change can ensure the URL
can navigate to what the user is seeing.
@kojiishi
Fix "all" to remove the URL parameter
d109d3c
@kojiishi kojiishi force-pushed the switch-lang-to-url-search-params branch from 10fdb5e to d109d3c Compare February 14, 2024 16:00
@kojiishi
Copy link
Contributor Author

kojiishi commented Feb 14, 2024

Thanks for the approval. I rebased to the ToT and confirmed it's still working. I was actually a bit scary because the original patch was 3 years ago ;-)

@kojiishi kojiishi merged commit 4a8330e into w3c:gh-pages Feb 14, 2024
@kojiishi kojiishi deleted the switch-lang-to-url-search-params branch February 14, 2024 16:05
deniak pushed a commit that referenced this pull request Mar 24, 2025
@kojiishi
Merge pull request #262 from kojiishi/switch-lang-to-url-search-params
b082d68 
Update URL when swithing the language in UI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@r12a r12a r12a approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update URL when the language is switched

3 participants

@kojiishi @kidayasuo @r12a