Make page-spread-center an alias for spread-none#1950
Conversation
shiestyle
left a comment
There was a problem hiding this comment.
I understand this change but most EPUB 3 files in Japan use 'page-spread-center' for 1st page as cover and we should avoid that EPUBCheck will recognize it as error and warning.
So alias is acceptable but deprecated is not good label.
That's what I was worried about. I'm perfectly fine with only making it an alias and not deprecating. |
clarify reason for the property in the note on aliases; additional minor cleanup of the page-spread-* section
# Conflicts: # epub33/core/index.html # epub33/rs/index.html
…to fix/issue-1929 # Conflicts: # epub33/core/index.html # epub33/rs/index.html
# Conflicts: # epub33/core/index.html # epub33/rs/index.html
|
Last few commits make the following changes:
|
|
The issue was discussed in a meeting on 2021-12-09
View the transcript2. Is page-spread-center a synthetic spread or not? (issue epub-specs#1929)See github issue epub-specs#1929. See github pull request epub-specs#1950. Wendy Reid: i just got through writing the tests for all the FXL rendition properties, which lead to a question about page-spread-center. Brady Duga: not sure why page-spread-center is confusing. Imagine you are doing a synthetic spread, but you want one specific page centered in the middle of the screen. That's how you would tell the RS to do that.. Wendy Reid: an additional level of oddness was finding out that you can put page spread properties on spine level items as well. Brady Duga: spread none and spread center mean different things, because spread none doesn't tell you where to put the page. Dave Cramer: is there a concern that this could affect the relative size of pages as you go from spread, to non-spread, and back to spread?. Brady Duga: i can't see people really doing this. Shinya Takami (高見真也): in Japan we use spread-center for the cover pages in many many cases, so making spread-center a depreciated feature would not be acceptable. Wendy Reid: right, so we won't deprecate page-spread-center. Dave Cramer: i'm not comfortable deciding this until we have more info on whether we need to better define how a RS should position the viewport when you use page-spread-center or spread none as an override of a synthetic spread epub. Wendy Reid: agree that the FXL properties section could use some visual aides. Brady Duga: if we end up keeping page spread then we need to fix this definition. Wendy Reid: yeah, definitions in that section are not very good. Dave Cramer: it was a long time ago that we wrote those, we were balancing against implementations that already existed at the time (amazon, apple). |
The only concern I have now that I'm opening the PR is whether we should formally deprecate page-spread-center or if we should "discourage" its use. I don't know if anyone has used it that we'd affect by this change.
Otherwise, the PR itself removes all traces of page-spread-center except to deprecate and make it an alias and adds the centering prose to the rendition:spread none processing requirements.
Preview | Diff