Skip to content

[css-gaps-1] Update gap decoration behavior when gaps are coincident due to track collapsing #11814#13298

Merged
kbabbitt merged 6 commits into
w3c:mainfrom
oSamDavis:collapsed-track
Jan 7, 2026
Merged

[css-gaps-1] Update gap decoration behavior when gaps are coincident due to track collapsing #11814#13298
kbabbitt merged 6 commits into
w3c:mainfrom
oSamDavis:collapsed-track

Conversation

@oSamDavis

@oSamDavis oSamDavis commented Jan 5, 2026

Copy link
Copy Markdown
Collaborator

This PR updates the logic of assigning gap decorations to gaps that are coincident due to track collapsing. Previously, border-collapsing rules were used to resolve conflicts. Now, following the new resolution taken in #11814, gap decorations are applied after collapsing, treating all coincident gaps as a single visible gap for decoration purposes.

@oSamDavis oSamDavis requested a review from kbabbitt January 5, 2026 20:49
kbabbitt
kbabbitt reviewed Jan 5, 2026
View reviewed changes

@kbabbitt kbabbitt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good overall; made a few wording suggestions to tighten up precision.

Comment thread css-gaps-1/Overview.bs Outdated
Comment thread css-gaps-1/Overview.bs Outdated
Comment thread css-gaps-1/Overview.bs Outdated
Comment thread css-gaps-1/Overview.bs Outdated
Comment thread css-gaps-1/Overview.bs Outdated
@kbabbitt

kbabbitt commented Jan 6, 2026

Copy link
Copy Markdown
Collaborator

Just thought of something else. Do we have any test cases covering the collapsing behavior yet, and if so could we add them to a <wpt> element near this paragraph? (If we don't have any test cases for this yet, I wouldn't block the PR on having them - we can add them later.)

oSamDavis and others added 5 commits January 7, 2026 08:40
@oSamDavis @kbabbitt
Update css-gaps-1/Overview.bs
4557bfc 
Co-authored-by: Kevin Babbitt <kbabbitt@microsoft.com>
@oSamDavis @kbabbitt
Update css-gaps-1/Overview.bs
ccf18f4 
Co-authored-by: Kevin Babbitt <kbabbitt@microsoft.com>
@oSamDavis @kbabbitt
Update css-gaps-1/Overview.bs
ace84c3 
Co-authored-by: Kevin Babbitt <kbabbitt@microsoft.com>
@oSamDavis @kbabbitt
Update css-gaps-1/Overview.bs
ce56bc0 
Co-authored-by: Kevin Babbitt <kbabbitt@microsoft.com>
@oSamDavis @kbabbitt
Update css-gaps-1/Overview.bs
d3170ce 
Co-authored-by: Kevin Babbitt <kbabbitt@microsoft.com>
@oSamDavis

oSamDavis commented Jan 7, 2026

Copy link
Copy Markdown
Collaborator Author

Just thought of something else. Do we have any test cases covering the collapsing behavior yet, and if so could we add them to a <wpt> element near this paragraph? (If we don't have any test cases for this yet, I wouldn't block the PR on having them - we can add them later.)

I don't think we have a set of wpts explictly testing these. But I'll create a crbug to add them so we don't lose track of this.

@kbabbitt kbabbitt merged commit feb4068 into w3c:main Jan 7, 2026
1 check passed
@kbabbitt kbabbitt linked an issue Jan 8, 2026 that may be closed by this pull request
[css-gaps] Gap decorations with collapsed gutters #11814
Closed
jav099 pushed a commit to jav099/javier-gaps-1 that referenced this pull request Jan 9, 2026
@oSamDavis
[css-gaps-1] Update gap decoration behavior when gaps are coincident …
95dcc9b 
…due to track collapsing w3c#11814 (w3c#13298)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kbabbitt kbabbitt kbabbitt approved these changes

Assignees

No one assigned

Labels

css-gaps-1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[css-gaps] Gap decorations with collapsed gutters

2 participants

@oSamDavis @kbabbitt