Skip to content

[mediaqueries-4] Add note about min-/max- shortcoming vs proper range context#1083

Merged
tabatkins merged 1 commit intow3c:masterfrom
patrickhlauke:mq4-range-vs-minmax
Mar 7, 2017
Merged

[mediaqueries-4] Add note about min-/max- shortcoming vs proper range context#1083
tabatkins merged 1 commit intow3c:masterfrom
patrickhlauke:mq4-range-vs-minmax

Conversation

@patrickhlauke
Copy link
Member

@patrickhlauke patrickhlauke commented Mar 7, 2017 •
edited
Loading

Closes #984

@patrickhlauke patrickhlauke changed the title Add note about min-/max- shortcoming vs proper range context [mediaqueries-4] Add note about min-/max- shortcoming vs proper range context Mar 7, 2017
@tabatkins
Copy link
Member

tabatkins commented Mar 7, 2017

👍 to the note (tho given its length, I might reformat it into a <details>), but please remove the extra <div class=note> you've added; it's extraneous, as a paragraph starting with "Note: " is automatically picked up by Bikeshed and formatted accordingly already.

@patrickhlauke
Copy link
Member Author

patrickhlauke commented Mar 7, 2017

it's extraneous, as a paragraph starting with "Note: " is automatically picked up by Bikeshed

oops, wasn't aware of that. just force-pushed an updated version of this PR. see what you think (wrapped the whole "For instance..." part into a <div class="example"> which perhaps makes more sense now...

@tabatkins
Copy link
Member

tabatkins commented Mar 7, 2017

Ooh, much better. Thanks!

@tabatkins tabatkins merged commit 57b7983 into w3c:master Mar 7, 2017
@patrickhlauke patrickhlauke mentioned this pull request Mar 7, 2017
Closed
@patrickhlauke patrickhlauke mentioned this pull request Oct 8, 2017
Merged
@phistuck
Copy link
Contributor

phistuck commented Oct 15, 2017

Is this supposed to work on any browser at the moment?
data:text/html,<!doctype html><style>@media (width < 320px) { html {background: black} }</style>
Does not show black on my desktop Chrome or Firefox.

@patrickhlauke
Copy link
Member Author

patrickhlauke commented Oct 15, 2017

@phistuck this isn't really the best place to ask about current browser support, but: currently, I believe range context is not supported by any (?) browsers. (additionally, once they support it, it would only be browsers/windows with a viewport smaller than 320px that show black, so on desktop this would only happen if you made the window small and/or zoomed in)

@phistuck
Copy link
Contributor

phistuck commented Oct 15, 2017

@patrickhlauke -

  1. You are correct, I apologize - I got here from a Twitter suggestion for solving that problem, so I let myself go a bit because I thought it was a relevant suggestion and perhaps not a futuristic feature. ;)
  2. It was a mistake, I meant > (I tried that as well).

Thank you!

patrickhlauke added a commit to patrickhlauke/csswg-drafts that referenced this pull request Oct 17, 2017
@patrickhlauke
Expand example for min-/max- shortcoming vs proper range context
b9d9953 
A follow-up to w3c#1083 that further expands the example to also include use of high-precision values (while we wait for browsers to support range context queries)
patrickhlauke added a commit to patrickhlauke/csswg-drafts that referenced this pull request Oct 17, 2017
@patrickhlauke
Expand example for min-/max- shortcoming vs proper range context
98ff70c 
A follow-up to w3c#1083 that further expands the example to also include use of high-precision values (while we wait for browsers to support range context queries)
@patrickhlauke patrickhlauke mentioned this pull request Oct 17, 2017
Merged
@patrickhlauke patrickhlauke deleted the mq4-range-vs-minmax branch May 30, 2020 10:59
@andersk andersk mentioned this pull request Feb 4, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@patrickhlauke @tabatkins @phistuck