“the worker's Documents” ➡ “owner set”#1124
Conversation
|
This change correctly rewrite what was there before, which is probably a good first step. But I'm not sure what was there actually makes sense. |
Me neither. So I guess this an chance to get some fresh review of the requirements in this paragraph Of course feel free to add more requested reviewers. On my own I’m not sure who to pick |
|
It should have been my bad having misunderstood the worker's Document back then. I'll find time to figure out what we should do to fix it. |
|
Oh, I didn't see this. In #1130 I just updated it to be a vague "the worker's owners". I guess I should not do that given that we're unsure what's going on. |
|
I think that's fine as at least it's not a broken link. We can then file a new issue on defining the lifetime of service workers and what changes to HTML might be needed for that. |
|
(And what changes to Service workers...) |
|
Marked as non-substantive for IPR from ash-nazg. |
docs/index.bs
Outdated
| When the request's [=request/url=] is not <a lt="is local">local</a>, a [=/service worker client=] <a lt="Match Service Worker Registration">matches</a> a [=/service worker registration=] from <a>scope to registration map</a>. That is, the [=/service worker client=] attempts to consult a [=/service worker registration=] whose [=service worker registration/scope url=] <a lt="Match Service Worker Registration">matches</a> its <a>creation URL</a>. | ||
|
|
||
| When the request's [=request/url=] <a>is local</a>, if the [=/service worker client=]'s <a>responsible browsing context</a> is a <a>nested browsing context</a> or the [=/service worker client=] is a <a>worker client</a>, the [=/service worker client=] inherits the [=/service worker registration=] from its <a>parent browsing context</a>'s environment or one of <a>the worker's Documents</a>' environment, respectively, if it exists. | ||
| When the request's [=request/url=] <a>is local</a>, if the [=/service worker client=]'s <a>responsible browsing context</a> is a <a>nested browsing context</a> or the [=/service worker client=] is a <a>worker client</a>, the [=/service worker client=] inherits the [=/service worker registration=] from its <a>parent browsing context</a>'s environment or from the environment of a {{Document}} in the [=/service worker client=]'s <a>active service worker</a>'s [=owner set=], respectively, if it exists. |
There was a problem hiding this comment.
I'll sort out the SW inheritance anyway, but this line should be:
s/<a>active service worker</a>/[=environment settings object/global object=]/.
|
@sideshowbarker, could you address #1124 (review) and rebase? |
7e07869 to
ce9f132
Compare
This aligns with the changes made in whatwg/html#2520 whatwg/html@59a4750
ce9f132 to
ba7aa8f
Compare
Yup, done |
|
Thanks. I'll merge this and put some additional change: relevant owner concept from HTML can be used to simply it I think.
#765 and whatwg/html#2080 track the relevant spec issues and efforts. |
This aligns with the changes made in whatwg/html#2520
whatwg/html@59a4750