feat(language-service): strip ="" for boolean props completion edits#5888
Merged
KazariEX merged 9 commits intovuejs:masterfrom Jan 5, 2026
Merged
feat(language-service): strip ="" for boolean props completion edits#5888KazariEX merged 9 commits intovuejs:masterfrom
="" for boolean props completion edits#5888KazariEX merged 9 commits intovuejs:masterfrom
Conversation
217d574 to
a202bc7
Compare
8c3584c to
f36bc6c
Compare
ee9f2e4 to
ab594f1
Compare
KazariEX
added a commit
that referenced
this pull request
Jan 5, 2026
theiter8r
pushed a commit
to theiter8r/vue
that referenced
this pull request
Mar 12, 2026
Pin the Vue language server to version 3.2.1 to work around a crash in @vue/language-service where `meta?.props.map(...)` throws a TypeError when `meta.props` is undefined. This bug was introduced upstream in vuejs/language-tools#5888 and affects @vue/language-server versions 3.2.2+. Upstream issue: vuejs/language-tools#5956 Fixes: zed-extensions#92
theiter8r
added a commit
to theiter8r/vue
that referenced
this pull request
Mar 12, 2026
Pin the Vue language server to version 3.2.1 to work around a crash in @vue/language-service where `meta?.props.map(...)` throws a TypeError when `meta.props` is undefined. This bug was introduced upstream in vuejs/language-tools#5888 and affects @vue/language-server versions 3.2.2+. Upstream issue: vuejs/language-tools#5956 Fixes: zed-extensions#92
MrSubidubi
pushed a commit
to zed-extensions/vue
that referenced
this pull request
Mar 18, 2026
## Problem The Vue language server crashes silently in Zed when providing attribute completions. The crash originates in `@vue/language-service` at `vue-template.js:604`, where the code uses: ```js meta?.props.map(prop => [prop.name, prop]) ?? [] ``` This throws a `TypeError: Cannot read properties of undefined (reading 'map')` when `meta` exists but `meta.props` is `undefined`. The safe form would be `meta?.props?.map(...)`. This bug was introduced upstream in [vuejs/language-tools#5888](vuejs/language-tools#5888) and affects `@vue/language-server` versions **3.2.2+**. **Upstream issue:** vuejs/language-tools#5956 ## Solution Pin `@vue/language-server` to version **3.2.1** (the last known working version before the buggy change) instead of dynamically fetching the latest version via `npm_package_latest_version`. This is a temporary workaround. Once the upstream package publishes a fix, the pin should be removed so users can receive future updates. ## Changes - Added a `PINNED_SERVER_VERSION` constant set to `"3.2.1"` with a comment explaining the reason and linking to the upstream issue. - Replaced `zed::npm_package_latest_version(PACKAGE_NAME)?` with `PINNED_SERVER_VERSION.to_string()` in `server_script_path`. - Added a `TODO` comment to remove the pin once upstream is fixed. Fixes #92 Co-authored-by: theiter8r <theiter8r@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.