Skip to content

fix(language-core): enhance getVIfNode to support v-else-if directives#5765

Merged
johnsoncodehk merged 15 commits intovuejs:masterfrom
serkodev:fix/5492
Nov 26, 2025
Merged

fix(language-core): enhance getVIfNode to support v-else-if directives#5765
johnsoncodehk merged 15 commits intovuejs:masterfrom
serkodev:fix/5492

Conversation

@serkodev
Copy link
Copy Markdown
Member

@serkodev serkodev commented Nov 19, 2025

Fixed #5492

5492

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Nov 19, 2025

Open in StackBlitz

vue-component-meta

npm i https://pkg.pr.new/vuejs/language-tools/vue-component-meta@5765

vue-component-type-helpers

npm i https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@5765

@vue/language-core

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-core@5765

@vue/language-plugin-pug

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@5765

@vue/language-server

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-server@5765

@vue/language-service

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-service@5765

vue-tsc

npm i https://pkg.pr.new/vuejs/language-tools/vue-tsc@5765

@vue/typescript-plugin

npm i https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@5765

commit: 963a2be

@serkodev serkodev changed the title fix(language-core): enhance getVIfNode to support else-if directives fix(language-core): enhance getVIfNode to support v-else-if directives Nov 19, 2025
@serkodev serkodev marked this pull request as ready for review November 19, 2025 20:19
@KazariEX
Copy link
Copy Markdown
Member

This will cause v-else-if to be generated as a seperate if statement, preventing type narrowing from working correctly.

@serkodev
Copy link
Copy Markdown
Member Author

Oh you're right. Let me think of another approach.

@serkodev serkodev marked this pull request as draft November 20, 2025 05:39
@serkodev serkodev marked this pull request as ready for review November 26, 2025 10:57
@johnsoncodehk johnsoncodehk merged commit 5548db0 into vuejs:master Nov 26, 2025
9 checks passed
so1ve pushed a commit to so1ve-forks/language-tools that referenced this pull request Dec 2, 2025
…tives (vuejs#5765)

Co-authored-by: Johnson Chu <johnsoncodehk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v-else-if and v-slot co-usage triggers false ts-plugin(6133) "unused" warning/error

3 participants