fix(tsc): point to shimmed tsc entry point to support ts 5.7 by davidmatter · Pull Request #5020 · vuejs/language-tools

davidmatter · 2024-11-25T07:42:57Z

Typescript 5.7 uses the tsc.js entrypoint for handling the node compile cache. This fix points to the new _tsc.js entry point but doesn't handle anything regarding the node compile cache. This needs to be looked at in a future release.

Resolves #5018

Typescript 5.7 uses the `tsc.js` entrypoint for handling the node compile cache. This fix points to the new `_tsc.js` entry point but doesn't handle anything regarding the node compile cache. This needs to be looked at in a future release.

pkg-pr-new · 2024-11-25T07:43:43Z

Open in Stackblitz

vue-component-meta

npm i https://pkg.pr.new/vuejs/language-tools/vue-component-meta@5020

@vue/language-core

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-core@5020

vue-component-type-helpers

npm i https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@5020

@vue/language-plugin-pug

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@5020

@vue/language-server

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-server@5020

vue-tsc

npm i https://pkg.pr.new/vuejs/language-tools/vue-tsc@5020

@vue/language-service

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-service@5020

@vue/typescript-plugin

npm i https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@5020

commit: b8befb2

rchl · 2024-11-25T07:51:55Z

Won't that break in older typescript versions instead?

davidmatter · 2024-11-25T07:59:20Z

You're right - that was an early Monday morning PR. Let me have another look

packages/tsc/index.ts

Co-authored-by: Danila Rodichkin <daniluk4000@outlook.com>

ayZagen · 2024-11-25T19:14:11Z

I tried this fix on my pipeline but it throws the following error:

TypeError: Invalid Version: 5.7
 at new SemVer (/app/node_modules/.pnpm/semver@7.6.3/node_modules/semver/classes/semver.js:38:13)
 at compare (/app/node_modules/.pnpm/semver@7.6.3/node_modules/semver/functions/compare.js:3:32)
 at Object.gte (/app/node_modules/.pnpm/semver@7.6.3/node_modules/semver/functions/gte.js:2:30)

daniluk4000 · 2024-11-25T20:03:37Z

Seems like it should be 5.7.0...

Smrtnyk · 2024-12-01T12:05:21Z

what is blocking this PR from being merged?

ujwal-setlur · 2024-12-04T17:25:58Z

Any idea when this is going to get merged? I feel this is pretty important to get out there.

FloEdelmann · 2024-12-05T11:09:09Z

At least 2 approving reviews are required by reviewers with write access.

Since @zhiyuanzmj and @KazariEX have both approved, this requirement is now fulfilled.

daniluk4000 · 2024-12-05T11:39:05Z

@davidmatter could you please resolve lockfile conflicts while we wait?

ujwal-setlur · 2024-12-06T16:58:35Z

I hate to be a pain on an open source project, but respectfully, there needs to be a sense of urgency to get this merged and released. This is blocking upgrade to TypeScript 5.7, and other dependencies that have already been updated for TS 5.7.

daniluk4000 · 2024-12-06T17:08:50Z

I hate to be a pain on an open source project, but respectfully, there needs to be a sense of urgency to get this merged and released. This is blocking upgrade to TypeScript 5.7, and other dependencies that have already been updated for TS 5.7.

And this is not the first time this happens here...

ST-DDT

Tested with https://github.com/faker-js/playground using

  "pnpm": {
    "overrides": {
      "vue-tsc": "link:../language-tools/packages/tsc"
    }
  }

Works as expected.

zhiyuanzmj · 2024-12-09T06:16:00Z

You can use pnpm i https://pkg.pr.new/vuejs/language-tools/vue-tsc@b8befb2 to using it temporarily.

tbsvttr · 2024-12-11T09:35:37Z

Thanks for all your work! Any idea when a versioned release on npm will follow? At the moment this problem blocks a lot of possible upgrades to TypeScript 5.7 and in a lot of project it is not feasible to add none released package versions as a dependency.

Waiting for vuejs/language-tools#5020.

dargmuesli · 2024-12-30T20:39:20Z

v2.2.0 was released containing this fix 🥳

davidmatter requested review from KazariEX, johnsoncodehk, kermanx, so1ve and zhiyuanzmj as code owners November 25, 2024 07:42

KazariEX previously approved these changes Nov 25, 2024

View reviewed changes

davidmatter marked this pull request as draft November 25, 2024 07:57

fix: compatibility

49c1772

KazariEX dismissed their stale review via 49c1772 November 25, 2024 08:03

davidmatter marked this pull request as ready for review November 25, 2024 08:15

davidmatter requested a review from KazariEX November 25, 2024 08:15

davidmatter mentioned this pull request Nov 25, 2024

vue-tsc doesn't work with typescript 5.7.2 #5018

Closed

daniluk4000 reviewed Nov 25, 2024

View reviewed changes

packages/tsc/index.ts Outdated Show resolved Hide resolved

Update packages/tsc/index.ts

35b9536

Co-authored-by: Danila Rodichkin <daniluk4000@outlook.com>

daniluk4000 mentioned this pull request Nov 25, 2024

Support TypeScript 5.7 fi3ework/vite-plugin-checker#415

Closed

2 tasks

fix: correct version

5a02a5e

hateofhades mentioned this pull request Nov 26, 2024

Bump typescript from 5.6.3 to 5.7.2 BrewingBytes/BranchWise#208

Closed

zhiyuanzmj previously approved these changes Nov 26, 2024

View reviewed changes

hateofhades approved these changes Nov 26, 2024

View reviewed changes

sxzz mentioned this pull request Nov 26, 2024

chore(deps): update all non-major dependencies sxzz/ast-explorer#103

Merged

1 task

ntnyq mentioned this pull request Nov 27, 2024

fix(deps): update all non-major dependencies to ^0.65.0-beta.3 ntnyq/prettier-now#29

Merged

1 task

sxzz mentioned this pull request Nov 27, 2024

chore(deps): update npm packages oxc-project/playground#47

Merged

1 task

trydofor mentioned this pull request Dec 2, 2024

down typescript from 5.7.2 to 5.6.3 trydofor/professional-razor#106

Closed

yamanoku mentioned this pull request Dec 3, 2024

chore(deps): update dependency typescript to v5.7.2 yamanoku/vue_portfolio_template#2270

Merged

1 task

davidglezz approved these changes Dec 4, 2024

View reviewed changes

This was referenced Dec 5, 2024

chore(deps): update all non-major dependencies nonebot/registry#99

Merged

chore(deps): update all non-major dependencies MooncellWiki/prts-widgets#174

Merged

ST-DDT approved these changes Dec 8, 2024

View reviewed changes

Merge branch 'master' into davidmatter-patch-1

0484815

davidmatter dismissed stale reviews from KazariEX and zhiyuanzmj via 0484815 December 9, 2024 06:08

fix: pnpm lockfile

b8befb2

davidmatter requested review from KazariEX, daniluk4000 and zhiyuanzmj December 9, 2024 06:17

zhiyuanzmj approved these changes Dec 9, 2024

View reviewed changes

KazariEX approved these changes Dec 9, 2024

View reviewed changes

davidmatter merged commit 3fb59af into master Dec 9, 2024

davidmatter deleted the davidmatter-patch-1 branch December 9, 2024 06:20

stephenWanjala mentioned this pull request Dec 11, 2024

vue-tsc throws "Search string not found" error during type-checking #5041

Closed

mitar added a commit to peer/db that referenced this pull request Dec 11, 2024

Downgrade TypeScript.

cc6c05e

Waiting for vuejs/language-tools#5020.

hannes-mk mentioned this pull request Dec 16, 2024

Bump typescript from 5.6.3 to 5.7.2 in /frontend digitalservicebund/ris-adm-literature#4

Merged

This was referenced Dec 19, 2024

feat(client): client copied from telegram-bot repo beabee-communityrm/monorepo#91

Merged

build: fix TypeScript version beabee-communityrm/monorepo#113

Merged

takumus mentioned this pull request Dec 21, 2024

ts5.7でvue-tscが使えねい。 takumus/ImagePetaPeta#378

Open

Uh oh!

Conversation

davidmatter commented Nov 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Nov 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rchl commented Nov 25, 2024

Uh oh!

davidmatter commented Nov 25, 2024

Uh oh!

Uh oh!

ayZagen commented Nov 25, 2024

Uh oh!

daniluk4000 commented Nov 25, 2024

Uh oh!

Smrtnyk commented Dec 1, 2024

Uh oh!

ujwal-setlur commented Dec 4, 2024

Uh oh!

FloEdelmann commented Dec 5, 2024

Uh oh!

daniluk4000 commented Dec 5, 2024

Uh oh!

ujwal-setlur commented Dec 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daniluk4000 commented Dec 6, 2024

Uh oh!

ST-DDT left a comment

Choose a reason for hiding this comment

Uh oh!

zhiyuanzmj commented Dec 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tbsvttr commented Dec 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dargmuesli commented Dec 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

davidmatter commented Nov 25, 2024 •

edited

Loading

pkg-pr-new bot commented Nov 25, 2024 •

edited

Loading

ujwal-setlur commented Dec 6, 2024 •

edited

Loading

zhiyuanzmj commented Dec 9, 2024 •

edited

Loading

tbsvttr commented Dec 11, 2024 •

edited

Loading