fix: correctly resolve types from relative paths on Windows#9446
Merged
yyx990803 merged 3 commits intovuejs:mainfrom Oct 21, 2023
Merged
fix: correctly resolve types from relative paths on Windows#9446yyx990803 merged 3 commits intovuejs:mainfrom
yyx990803 merged 3 commits intovuejs:mainfrom
Conversation
Closes vuejs#8671 Closes vuejs/vue-loader#2048 `dirname` is the safest way to get a directory name from a path string. As for this specific bug, it's because `path.posix.join(AnyWindowsPath, '..')` returns `.`. I'm not sure whether there will be unexpected regression if I modify the `joinPaths` utility, so I changed the smallest possible bit of code to fix this.
Size ReportBundles
Usages
|
Because in the Windows test case, the resolved path isn't normalized (`C:\\Test/foo`), which, though doesn't affect real-world usage, would fail in the mock file system.
yyx990803
pushed a commit
that referenced
this pull request
Oct 21, 2023
lumozx
pushed a commit
to lumozx/core
that referenced
this pull request
Oct 21, 2023
yyx990803
pushed a commit
that referenced
this pull request
Nov 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8671
Closes vuejs/vue-loader#2048
dirnameis the safest way to get a directory name from a path string.As for this specific bug, it's because
path.posix.join(AnyWindowsPathUsingBackSlashes, '..')returns..I'm not sure whether there will be unexpected regression if I modify the
joinPathsutility, so I changed the smallest possible bit of code to fix this.