Skip to content

fix(runtime-dom): correctly handle the v-if in TransitionGroup#14569

Closed
jackma9604 wants to merge 3 commits intovuejs:minorfrom
jackma9604:fix/Transition
Closed

fix(runtime-dom): correctly handle the v-if in TransitionGroup#14569
jackma9604 wants to merge 3 commits intovuejs:minorfrom
jackma9604:fix/Transition

Conversation

@jackma9604
Copy link
Copy Markdown

@jackma9604 jackma9604 commented Mar 14, 2026

fix: #14564

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 14, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 815a14df-9696-4582-943d-e2db16ee27b1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 14, 2026 •
edited
Loading

Open in StackBlitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@14569

npm i https://pkg.pr.new/@vue/compiler-core@14569

yarn add https://pkg.pr.new/@vue/compiler-core@14569.tgz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@14569

npm i https://pkg.pr.new/@vue/compiler-dom@14569

yarn add https://pkg.pr.new/@vue/compiler-dom@14569.tgz

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@14569

npm i https://pkg.pr.new/@vue/compiler-sfc@14569

yarn add https://pkg.pr.new/@vue/compiler-sfc@14569.tgz

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@14569

npm i https://pkg.pr.new/@vue/compiler-ssr@14569

yarn add https://pkg.pr.new/@vue/compiler-ssr@14569.tgz

@vue/compiler-vapor

pnpm add https://pkg.pr.new/@vue/compiler-vapor@14569

npm i https://pkg.pr.new/@vue/compiler-vapor@14569

yarn add https://pkg.pr.new/@vue/compiler-vapor@14569.tgz

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@14569

npm i https://pkg.pr.new/@vue/reactivity@14569

yarn add https://pkg.pr.new/@vue/reactivity@14569.tgz

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@14569

npm i https://pkg.pr.new/@vue/runtime-core@14569

yarn add https://pkg.pr.new/@vue/runtime-core@14569.tgz

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@14569

npm i https://pkg.pr.new/@vue/runtime-dom@14569

yarn add https://pkg.pr.new/@vue/runtime-dom@14569.tgz

@vue/runtime-vapor

pnpm add https://pkg.pr.new/@vue/runtime-vapor@14569

npm i https://pkg.pr.new/@vue/runtime-vapor@14569

yarn add https://pkg.pr.new/@vue/runtime-vapor@14569.tgz

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@14569

npm i https://pkg.pr.new/@vue/server-renderer@14569

yarn add https://pkg.pr.new/@vue/server-renderer@14569.tgz

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@14569

npm i https://pkg.pr.new/@vue/shared@14569

yarn add https://pkg.pr.new/@vue/shared@14569.tgz

vue

pnpm add https://pkg.pr.new/vue@14569

npm i https://pkg.pr.new/vue@14569

yarn add https://pkg.pr.new/vue@14569.tgz

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@14569

npm i https://pkg.pr.new/@vue/compat@14569

yarn add https://pkg.pr.new/@vue/compat@14569.tgz

commit: 2adce3e

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 14, 2026

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 86.4 kB 30.2 kB 26.6 kB
runtime-dom.global.prod.js 110 kB 41.6 kB 37.3 kB
vue.global.prod.js 169 kB 61.4 kB 54.7 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 50.3 kB 19.7 kB 18 kB
createApp 59.3 kB 23 kB 20.9 kB
createApp + vaporInteropPlugin 83.4 kB (+28 B) 30.9 kB (+18 B) 28 kB (+15 B)
createVaporApp 28.8 kB 11.2 kB 10.2 kB
createSSRApp 63.5 kB 24.7 kB 22.4 kB
createVaporSSRApp 32.2 kB 12.4 kB 11.4 kB
defineCustomElement 65.3 kB 24.8 kB 22.5 kB
defineVaporCustomElement 39 kB 14.4 kB 13.3 kB
overall 74.2 kB 28.3 kB 25.7 kB

edison1105
edison1105 reviewed Mar 16, 2026
View reviewed changes
packages/runtime-vapor/src/components/Transition.ts
fragments.forEach(f => (f.$transition = resolvedHooks))

if (block instanceof ForFragment) {
setTransitionHooksOnFragment(block, {
Copy link
Copy Markdown
Member

@edison1105 edison1105 Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR.
The logic here essentially duplicates the internal logic of TransitionGroup; it should reuse the internal logic of TransitionGroup rather than re-implementing it. See #14571

@edison1105
Copy link
Copy Markdown
Member

edison1105 commented Mar 16, 2026

see #14569 (comment)

edison1105 added a commit that referenced this pull request Mar 16, 2026
@edison1105
fix(runtime-vapor): TransitionGroup with v-if + v-for not applying tr…
508edbe 
…ansition hooks (#14571)

close #14564
close #14569
@edison1105 edison1105 closed this Mar 16, 2026
@jackma9604 jackma9604 deleted the fix/Transition branch March 16, 2026 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edison1105 edison1105 edison1105 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jackma9604 @edison1105