fix(compiler-vapor): merge component v-model onUpdate handlers#14229
Merged
edison1105 merged 3 commits intominorfrom Dec 22, 2025
Merged
fix(compiler-vapor): merge component v-model onUpdate handlers#14229edison1105 merged 3 commits intominorfrom
edison1105 merged 3 commits intominorfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/compiler-vapor
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/runtime-vapor
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
There was a problem hiding this comment.
Pull request overview
This PR fixes the merging of component v-model onUpdate:* handlers with explicitly provided handlers of the same name. When a component has both v-model and an explicit @update:modelValue handler, they are now correctly merged into an array of handlers instead of overwriting each other.
Key changes:
- Refactored handler generation to group handlers by key name and merge multiple handlers into arrays
- Split the
extraWrapparameter ingenEventHandlerinto two separate parameters (asComponentPropandextraWrap) for clearer semantics - Moved v-model event handler and modifier generation from
genPropintogenStaticPropsfor proper deduplication
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/compiler-vapor/src/generators/event.ts |
Split extraWrap parameter into asComponentProp and extraWrap for clarity; updated comments and logic |
packages/compiler-vapor/src/generators/component.ts |
Refactored genStaticProps to group and merge handlers by key; moved v-model handler generation; removed genModelEvent and genModelModifiers helper functions; updated genDynamicProps to handle v-model with dynamic arguments |
packages/compiler-vapor/__tests__/transforms/vModel.spec.ts |
Added test for merging v-model with explicit @update:modelValue handler; added transformVOn to test configuration; updated existing test expectations |
packages/compiler-vapor/__tests__/transforms/__snapshots__/vModel.spec.ts.snap |
Updated snapshots with improved formatting and new test case snapshot showing merged handlers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zhiyuanzmj
added a commit
to vuejs/vue-jsx-vapor
that referenced
this pull request
Jan 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.