Skip to content

feat(runtime-vapor): v-html and v-text work with component#13496

Merged
edison1105 merged 8 commits intominorfrom
edison/fix/vhtmlAndvTextWithDynamicComponent
Oct 20, 2025
Merged

feat(runtime-vapor): v-html and v-text work with component#13496
edison1105 merged 8 commits intominorfrom
edison/fix/vhtmlAndvTextWithDynamicComponent

Conversation

@edison1105
Copy link
Copy Markdown
Member

@edison1105 edison1105 commented Jun 19, 2025

@netlify
Copy link
Copy Markdown

netlify bot commented Jun 19, 2025

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit a64867a
🔍 Latest deploy log https://app.netlify.com/projects/vapor-repl/deploys/6853830cd05a530008d8f931
😎 Deploy Preview https://deploy-preview-13496--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jun 19, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch edison/fix/vhtmlAndvTextWithDynamicComponent

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Jun 19, 2025

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13496

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13496

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13496

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13496

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@13496

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13496

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13496

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13496

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@13496

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13496

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13496

vue

npm i https://pkg.pr.new/vue@13496

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13496

commit: b702798

@edison1105 edison1105 added the scope: vapor related to vapor mode label Jun 19, 2025
Base automatically changed from vapor to minor July 7, 2025 00:06
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 16, 2025

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 84 kB (-526 B) 29.8 kB (-165 B) 26.3 kB (-102 B)
runtime-dom.global.prod.js 104 kB (-495 B) 39.1 kB (-140 B) 35.3 kB (-143 B)
vue.global.prod.js 162 kB (-495 B) 59.3 kB (-150 B) 52.9 kB (-102 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.2 kB (-123 B) 18.4 kB (-63 B) 16.9 kB (-43 B)
createApp 56 kB (-123 B) 21.6 kB (-51 B) 19.7 kB (-52 B)
createApp + vaporInteropPlugin 68.6 kB (-9.13 kB) 25.9 kB (-3.25 kB) 23.6 kB (-2.88 kB)
createVaporApp 21 kB (-9.52 kB) 8.33 kB (-3.42 kB) 7.62 kB (-3.11 kB)
createSSRApp 60.3 kB (-141 B) 23.3 kB (-62 B) 21.3 kB (-63 B)
defineCustomElement 61 kB (-123 B) 23.1 kB (-61 B) 21.1 kB (-52 B)
overall 70.5 kB (-346 B) 26.8 kB (-113 B) 24.4 kB (-114 B)

@LittleSound LittleSound mentioned this pull request Jul 22, 2025
22 tasks
@edison1105 edison1105 force-pushed the edison/fix/vhtmlAndvTextWithDynamicComponent branch from 396fa2a to da45770 Compare September 18, 2025 09:15
@edison1105 edison1105 changed the title feat(runtime-vapor): dynamic components work with v-html and v-text feat(runtime-vapor): v-html and v-text work with component Sep 18, 2025
} else if (isVaporComponent(block)) {
setTextToBlock(block.block, value)
} else if (isArray(block)) {
if (__DEV__) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a scenario where this could be a single-element array i.e. in which setTextToBlock(block[0], value) could be used? Likewise with setHtmlToBlock

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The behavior here is aligned with vdom's behavior: as long as it's an array, a warning is issued.

see playground

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, makes sense!

@edison1105 edison1105 merged commit 7870fc0 into minor Oct 20, 2025
17 checks passed
@edison1105 edison1105 deleted the edison/fix/vhtmlAndvTextWithDynamicComponent branch October 20, 2025 05:50
@github-project-automation github-project-automation bot moved this from Vapor to Done in Next Minor Oct 20, 2025
zhiyuanzmj added a commit to vuejs/vue-jsx-vapor that referenced this pull request Jan 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: vapor related to vapor mode version: minor

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants